Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve more inconsistencies in 32-bit systems #1214

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

Yantrio
Copy link
Member

@Yantrio Yantrio commented Jan 30, 2024

This issue fixes the 2 failing tests in 386 and arm based systems in the alpine build pipelines.

  • Resolves issue with integer overflow when constructing the s3 assume role timeout in the backend logic
  • Resolves issue where TestEncodePaths was comparing the order of slices, when the order returned from go-cty is non-deterministic (Due to hashing on 32 bit systems dropping half the data).

Resolves #1069

Target Release

1.7.0, 1.6.1

Yantrio and others added 2 commits January 30, 2024 13:37
Co-authored-by: Isaac Parker <parrotmac@gmail.com>
Signed-off-by: James Humphries <james@james-humphries.co.uk>
Signed-off-by: James Humphries <james@james-humphries.co.uk>
@Yantrio Yantrio requested a review from a team as a code owner January 30, 2024 18:55
Copy link

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

@Yantrio Yantrio merged commit 199ec89 into main Feb 2, 2024
10 checks passed
@Yantrio Yantrio deleted the 32-bit-fixes-2 branch February 2, 2024 13:46
Yantrio added a commit that referenced this pull request Feb 2, 2024
Signed-off-by: James Humphries <james@james-humphries.co.uk>
Co-authored-by: Isaac Parker <parrotmac@gmail.com>
Yantrio added a commit that referenced this pull request Feb 2, 2024
…1226)

Signed-off-by: James Humphries <james@james-humphries.co.uk>
Co-authored-by: Isaac Parker <parrotmac@gmail.com>
AmerAlkaki added a commit to AmerAlkaki/opentofu that referenced this pull request Feb 7, 2024
IgnorantSapient pushed a commit to IgnorantSapient/opentofu that referenced this pull request Apr 1, 2024
Signed-off-by: James Humphries <james@james-humphries.co.uk>
Co-authored-by: Isaac Parker <parrotmac@gmail.com>
Signed-off-by: Ashwin Annamalai <4549937+IgnorantSapient@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some tests fail for 32-bit builds in Alpine Linux CI
5 participants