Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for tofu init failure when test have spaces in their name #1489

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

siddharthasonker95
Copy link
Contributor

@siddharthasonker95 siddharthasonker95 commented Apr 14, 2024

Objective: Fix for tofu init failure when test have spaces in their name

Changes:

  • Added ValidIdentifier() check in decodeTestRunBlock()
  • Updated existing test cases that included space in it's run block name.

Resolves #1358

Target Release

1.7.0

Signed-off-by: siddharthasonker95 <158144589+siddharthasonker95@users.noreply.github.com>
Copy link

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

…lock name

Signed-off-by: siddharthasonker95 <158144589+siddharthasonker95@users.noreply.github.com>
Signed-off-by: siddharthasonker95 <158144589+siddharthasonker95@users.noreply.github.com>
@siddharthasonker95 siddharthasonker95 marked this pull request as ready for review April 15, 2024 16:47
@siddharthasonker95 siddharthasonker95 requested a review from a team as a code owner April 15, 2024 16:47
@siddharthasonker95 siddharthasonker95 changed the title corrected error when run block name has space Fix for tofu init failure when test have spaces in their name Apr 15, 2024
Yantrio
Yantrio previously approved these changes Apr 23, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@cam72cam
Copy link
Contributor

Looks like it hit #847, I've kicked off the tests again.

Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
@cam72cam cam72cam merged commit de30707 into main Apr 25, 2024
12 checks passed
@cam72cam cam72cam deleted the bug/tofu_test_blockname branch April 25, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tofu test - Fails to init when test has spaces in its name
3 participants