Fix GCS backend crash from encryption changes #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GCS backend is more eager than other backends we tested during the state encryption work. Some of the more peripheral commands were assumed to not need state encryption (incorrectly) and were passed nil. That nil was an explicit choice to pass an invalid value if accessed in case our assumptions around that code were wrong. We decided early on that we would rather panic than incorrectly disable encryption. The fix here is fairly straightforward, I've added the same encryption logic used by other commands into the commands I thought did not require explicit encryption configuration. Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
|
Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR. |
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
janosdebugs
approved these changes
May 7, 2024
cam72cam
added a commit
that referenced
this pull request
May 7, 2024
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
bunniseng
pushed a commit
to bunniseng/opentofu
that referenced
this pull request
May 28, 2024
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GCS backend is more eager than other backends we tested during the state encryption work. Some of the more peripheral commands were assumed to not need state encryption (incorrectly) and were passed nil.
That nil was an explicit choice to pass an invalid value if accessed in case our assumptions around that code were wrong. We decided early on that we would rather panic than incorrectly disable encryption.
The fix here is fairly straightforward, I've added the same encryption logic used by other commands into the commands I thought did not require explicit encryption configuration.
Resolves #1617
Target Release
1.7.1, 1.8.0