WIP Improve comparison of sensitive marks on resources, and propagate the sensitive_attributes correctly #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR. |
…values and merge all marks where possible Signed-off-by: James Humphries <james@james-humphries.co.uk>
Yantrio
force-pushed
the
sensitive_attributes_from_schema
branch
from
a3a8433
to
1f2bdd3
Compare
Signed-off-by: James Humphries <james@james-humphries.co.uk>
Signed-off-by: James Humphries <james@james-humphries.co.uk>
Signed-off-by: James Humphries <james@james-humphries.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I've marked this as a WIP so that I can get github to build this for and report test failures in a lazy way! Please hold off on reviews until tests are in.
This PR resolves 2 things primarily.
It also introduced a method to combine
[]cty.PathValueMarkwhich is used to ensure thatsensitive_attributesare not being thrown away.This is used to combine the existing value marks with the marks from the configuration.
Because we handle it this way now, the sensitive_attributes value in the statefile will now include all sensitive properties and not just those where a sensitive value was passed in.
Resolves #1616
Target Release
1.8.0