fix(s3): allow aliases for kms key #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew den Hertog <andrew@denhertog.ca>
|
Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR. |
marcinwyszynski
added
the
accepted
|
@andrewhertog would you mind adding the changelog entry as part of this PR? Otherwise having read the relevant S3 and KMS docs multiple times I see no reason whatsoever to disallow key aliases. |
marcinwyszynski
approved these changes
Oct 6, 2023
maunzCache
reviewed
Oct 6, 2023
Signed-off-by: Andrew den Hertog <andrew@denhertog.ca>
Signed-off-by: Andrew den Hertog <andrew@denhertog.ca>
andrewhertog
force-pushed
the
fix/s3-backend-kms-alias
branch
from
9bb97ad
to
0f10090
Compare
Signed-off-by: Andrew den Hertog <andrew@denhertog.ca>
|
Thanks a lot for your contribution @andrewhertog ! |
thumperward
pushed a commit
to thumperward/opentf
that referenced
this pull request
Jan 10, 2024
Signed-off-by: Andrew den Hertog <andrew@denhertog.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 1.6.0 broke the ability to use s3 key aliases in the s3 backend. This change adjusts the tests, and validation of kms key arn's to look for aliases
Resolves #669
Target Release
1.6.0
Draft CHANGELOG entry
BUG FIXES