More in depth refactoring of providers and modules #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
There's still a lot of copy-paste in the command structure I'll probably address that in a subsequent PR Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
janosdebugs
reviewed
Dec 15, 2023
| "log/slog" | ||
| ) | ||
|
|
||
| type Repository struct { |
There was a problem hiding this comment.
Since this seems to be called sometimes without log, maybe adding explicit constructor(s), even if not exported, would be beneficial? That would document what the required parameters are.
| ghClient: c.ghClient, | ||
| func (c Client) Repository(owner, name string, log *slog.Logger) Repository { | ||
| return Repository{ | ||
| client: Client{ |
There was a problem hiding this comment.
Does this not need a log here? See my comment about constructors.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Fixes #30