Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php 8.1 and php 8.2 to github actions build matrix #332

Merged
merged 2 commits into from
May 26, 2023

Conversation

pascalheidmann
Copy link

Description

Adding recent versions of PHP to build matrix

Motivation and Context

PHP 8.1 is out for 1.5 years, php 8.2 for half a year. Still they aren't part of the automatic test matrix

How Has This Been Tested?

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

AnnaDamm
AnnaDamm previously approved these changes May 24, 2023
@SecondeJK SecondeJK changed the base branch from main to dev May 26, 2023 07:57
@SecondeJK SecondeJK dismissed AnnaDamm’s stale review May 26, 2023 07:57

The base branch was changed.

@SecondeJK SecondeJK self-assigned this May 26, 2023
@SecondeJK SecondeJK self-requested a review May 26, 2023 07:57
@SecondeJK
Copy link
Contributor

Changed to merge to dev, which will then require me to merge dev into main.

@SecondeJK SecondeJK merged commit d6e93ba into opentok:dev May 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants