Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to Main release #343

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Dev to Main release #343

merged 3 commits into from
Sep 25, 2023

Conversation

SecondeJK
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #343 (5d255be) into main (b6e8256) will decrease coverage by 0.1%.
Report is 1 commits behind head on main.
The diff coverage is 80.0%.

Files Changed Coverage Δ
src/OpenTok/Util/Client.php 74.8% <73.3%> (-0.1%) ⬇️
src/OpenTok/OpenTok.php 92.0% <100.0%> (+0.3%) ⬆️

@SecondeJK
Copy link
Contributor Author

Coverage is failing by 0.1% because of error handling which all isn't tested.
It would be a major refactor to the codebase in order to make this testable, and considering this will be switched to the core client it makes no point trying to get codecov to pass.

@SecondeJK SecondeJK merged commit 3fe0e17 into main Sep 25, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant