Skip to content

Commit

Permalink
Fixes NullReferenceException in CreateSession (#114)
Browse files Browse the repository at this point in the history
* Better handle WebExceptions that don't have a Response and send a customized exception on WebExceptionStatus.SendFailure errors (usually from TLS errors).
Fixes #108.

* Adding extra instructions regarding TLS to readme, adding new exception handling if TLS is incorrect

* removing erroneously added whitespace

* list archive by session id, better exception handling for validateSessionid

* removing extra whitespace from tests

* cleaning up other whitespace issues

* passing inner exception to OpenTokException

* Fixing comments, removing redundant fields

* adding custom layout for archiving

* fixing spacing issue, adding javadocs to StartArchive for layout

* revving to 3.4

* adding extra Archive Test

* Adding non-custom with stylesheet case

* adding contract annotations to ArchiveLayout to prevent invalid serialization of the stylesheet for non-custom layouts

* bringing balance to the force

* Dropping core 3.0 tests

* moving back to newer container

* removing .net core 2.x runs

* Silenced warnings in the test project.

* empty Statement Redundancy Fix

* Spell Fix

* Spell Fix

* Spell Fix | GetPartnerIdFromSessionId

Spell Fix | GetPartnerIdFromSessionId method's Property

* moving dotnet version

* specifying test framework

* Changed Javadoc comments to XML comments.

* Replace <see href with <a href.

* Added additional comments.

* Revving to 3.5.0

* automatic release on new GitHub release

* adding OUTPUT_PATH

* fixing Windows CI issue

* updating nexmo/github-actions branch to main

* screenshare layout

* more tests

* Adding SetArchiveLayout, updating unit tests

* moving null ignore to data structure

* fixing error message

* fixing screenshareType

* revving to 3.6.0

* Removing travis config

* Removing travis, fixing GitHub Actions definitions and adding package settings in project file (#164)

* Docs corrections (#161)

Co-authored-by: Stephen Lorello <42971704+slorello89@users.noreply.github.com>
Co-authored-by: slorello89 <slorello89@gmail.com>
Co-authored-by: Dirk Lemstra <dirk@lemstra.org>
Co-authored-by: onpoc <gupta.pradeep506@gmail.com>
Co-authored-by: Matt Hunt <mattlethargic@gmail.com>
Co-authored-by: Jeff Swartz <jeff.swartz@vonage.com>
  • Loading branch information
7 people committed Nov 9, 2021
1 parent 9a4f463 commit fd313c7
Show file tree
Hide file tree
Showing 30 changed files with 1,632 additions and 860 deletions.
30 changes: 30 additions & 0 deletions .github/workflows/build.yml
@@ -0,0 +1,30 @@
name: "Build & Test"

on:
push:
branches: [ main, dev ]
pull_request:
branches: [ main, dev ]

env:
CONFIGURATION: "Release"

jobs:
build:

runs-on: windows-latest

steps:
- uses: actions/checkout@v2
- name: Setup .NET Core
uses: actions/setup-dotnet@v1
with:
dotnet-version: '3.1.401'
- name: Clean
run: dotnet clean OpenTok.sln --configuration ${{ env.CONFIGURATION }} && dotnet nuget locals all --clear
- name: Install dependencies
run: dotnet restore
- name: Build
run: dotnet build OpenTok.sln --configuration ${{ env.CONFIGURATION }} --no-restore
- name: Test
run: dotnet test OpenTokTest/OpenTokTest.csproj --configuration ${{ env.CONFIGURATION }} --no-build -f netcoreapp3.1
26 changes: 0 additions & 26 deletions .github/workflows/dotnet-core.yml

This file was deleted.

24 changes: 24 additions & 0 deletions .github/workflows/release.yml
@@ -0,0 +1,24 @@
name: Nuget Release
on:
release:
types: [published]
jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.release.target_commitish }}
- name: Release Nuget
uses: nexmo/github-actions/nuget-release@main
env:
PROJECT_FILE : OpenTok/OpenTok.csproj
BRANCH: main
ORGANIZATION: opentok
REPO: Opentok-.NET-SDK
TAG: ${{ github.event.release.tag_name }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NUGET_API_KEY: ${{ secrets.NUGET_API_KEY }}
GITHUB_USER_NAME: NexmoDev
GITHUB_EMAIL: 44278943+NexmoDev@users.noreply.github.com
OUTPUT_PATH: OpenTok/bin/Release
10 changes: 0 additions & 10 deletions .travis.yml

This file was deleted.

14 changes: 7 additions & 7 deletions OpenTok.sln
@@ -1,24 +1,24 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 16
VisualStudioVersion = 16.0.30114.105
# Visual Studio Version 17
VisualStudioVersion = 17.1.31903.286
MinimumVisualStudioVersion = 10.0.40219.1
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{DC02B3EA-F1B3-4A39-A151-4FE61A39F209}"
ProjectSection(SolutionItems) = preProject
.gitattributes = .gitattributes
.gitignore = .gitignore
.travis.yml = .travis.yml
appveyor.yml = appveyor.yml
.github\workflows\build.yml = .github\workflows\build.yml
CONTRIBUTING.md = CONTRIBUTING.md
DEVELOPING.md = DEVELOPING.md
README.md = README.md
.github\workflows\release.yml = .github\workflows\release.yml
EndProjectSection
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "HelloWorld", "Samples\HelloWorld\HelloWorld.csproj", "{F8A5A9AD-F680-46F4-806F-653E7E51A030}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "HelloWorld", "Samples\HelloWorld\HelloWorld.csproj", "{F8A5A9AD-F680-46F4-806F-653E7E51A030}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Archiving", "Samples\Archiving\Archiving.csproj", "{B6EFF9BA-20CD-4BDE-B67B-C8E22F00E640}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Archiving", "Samples\Archiving\Archiving.csproj", "{B6EFF9BA-20CD-4BDE-B67B-C8E22F00E640}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Broadcasting", "Samples\Broadcasting\Broadcasting.csproj", "{D593D74C-46D3-4947-9F57-B40D978C40B7}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Broadcasting", "Samples\Broadcasting\Broadcasting.csproj", "{D593D74C-46D3-4947-9F57-B40D978C40B7}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "OpenTok", "OpenTok\OpenTok.csproj", "{C770C266-B8E6-413A-B5AB-68EB218DC76C}"
EndProject
Expand Down

0 comments on commit fd313c7

Please sign in to comment.