Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break apart test dependencies and runtime dependencies #23

Closed
aoberoi opened this issue Mar 31, 2014 · 0 comments
Closed

break apart test dependencies and runtime dependencies #23

aoberoi opened this issue Mar 31, 2014 · 0 comments

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Mar 31, 2014

things to consider:

Travis runs pip install -r requirements.txt. this means we may need to add a test_requirements.txt file and make it also install that

the requirements.txt right now doesn't do anything in particular, just lets setup.py pick up dependencies. i was under the impression that this is better practice for libraries unless specific versions are required.

Tox is run to do testing locally, and tox.ini defines dependencies too. Right now it only declares nose as a dependency because it needs to run the nosetests binary. It works on the assumption that the sbin build that is already pip installed into the individual virtualenv has all the other dependencies that this library needs.

aoberoi added a commit to aoberoi/Opentok-Python-SDK that referenced this issue Apr 1, 2014
aoberoi added a commit to aoberoi/Opentok-Python-SDK that referenced this issue Apr 1, 2014
@aoberoi aoberoi closed this as completed Apr 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant