New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to 2.16.0 #46
update to 2.16.0 #46
Changes from 19 commits
d17c1c6
98c978c
e1f76ba
9f40004
1549b16
38bce5c
358dc38
2946059
69efd19
0ae1ebb
c8e972e
249223a
eab0eb3
8d2ac44
8fea3af
19fff9b
dc4549c
aab6d0a
028987d
539859c
16fdca5
ff3ea15
348b713
722d3fa
38c3255
9a4cc26
0c3c8fe
1f2c261
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,7 +87,8 @@ - (void)checkImageSize:(CGImageRef)image { | |
CVPixelBufferRelease(_pixelBuffer); | ||
} | ||
|
||
CVReturn status = CVPixelBufferCreate(kCFAllocatorDefault, | ||
CVReturn status; | ||
status = CVPixelBufferCreate(kCFAllocatorDefault, | ||
frameSize.width, | ||
frameSize.height, | ||
kCVPixelFormatType_32ARGB, | ||
|
@@ -140,8 +141,8 @@ - (int32_t)stopCapture | |
_capturing = NO; | ||
|
||
dispatch_sync(_queue, ^{ | ||
if (_timer) { | ||
dispatch_source_cancel(_timer); | ||
if (self->_timer) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. when you use self in a block it is good practice (to avoid reference loops) to capture a weak reference to it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks @robjperez. Fixed, please check again |
||
dispatch_source_cancel(self->_timer); | ||
} | ||
}); | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
project 'OTAcceleratorCore.xcodeproj' | ||
|
||
platform :ios, '9.0' | ||
platform :ios, '10.0' | ||
|
||
target 'OTAcceleratorCore' do | ||
pod 'OpenTok', '~>2.13' | ||
pod 'OpenTok', '2.16.1' | ||
pod 'OTKAnalytics', '= 2.1.0' | ||
pod 'SVProgressHUD', '= 2.2.1' | ||
end | ||
|
||
target 'OTAcceleratorCoreTests' do | ||
pod 'OpenTok', '~>2.13' | ||
pod 'OpenTok', '2.16.1' | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
PODS: | ||
- OpenTok (2.16.1) | ||
- OTKAnalytics (2.1.0) | ||
- SVProgressHUD (2.2.1) | ||
|
||
DEPENDENCIES: | ||
- OpenTok (= 2.16.1) | ||
- OTKAnalytics (= 2.1.0) | ||
- SVProgressHUD (= 2.2.1) | ||
|
||
SPEC REPOS: | ||
https://github.com/cocoapods/specs.git: | ||
- OpenTok | ||
- OTKAnalytics | ||
- SVProgressHUD | ||
|
||
SPEC CHECKSUMS: | ||
OpenTok: 556374577b66cbf791190c84612346c8f3997c9e | ||
OTKAnalytics: d959cb9037564ce382cf79f1e43d0bf03a9dcd60 | ||
SVProgressHUD: db27c54e6e18bc903341661fc9feb55e04905cc4 | ||
|
||
PODFILE CHECKSUM: 3e55596159deb74b60c363a77e595d958f6dc367 | ||
|
||
COCOAPODS: 1.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a good practice to run
pod deintegrate
before checking the project file.This way we remove pod reference in the project file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the suggestion @robjperez! Fixed, please check again