VIDCS-869: Fix crash when toggling video #462
Conversation
v-kpheng
changed the title
|
Has this been updated based on our default camera2 capturer? |
| /* | ||
| executeAfterCameraOpened = () -> { | ||
| cameraState = CameraState.CLOSING; | ||
| if (camera != null) { | ||
| camera.close(); | ||
| } | ||
| }; | ||
|
|
||
| */ | ||
| executeAfterCameraOpened = null; |
There was a problem hiding this comment.
If I remember well, this code should not be commented out, and the null assignment removed.
There was a problem hiding this comment.
I think the same. Not sure why this got commented out. May be we can check the history when this change was made.
...-Java/app/src/main/java/com/tokbox/sample/basicvideocapturercamera2/MirrorVideoCapturer.java
Show resolved
Hide resolved
...-Java/app/src/main/java/com/tokbox/sample/basicvideocapturercamera2/MirrorVideoCapturer.java
Outdated
Show resolved
Hide resolved
|
@juliobecerragomez @goncalocostamendes Those changes have been taken from the native SDK code. I haven't made any modifications other than renaming variables and fixing the logs. I think @jintgeorge would be best to reply to the comment here (cc @v-kpheng ) |
Yes, just confirmed it is the same as native SDK. Approving |
|
@vona-ben So at least we should fix the commented out code. I do not think it is ok to show it as part of the linux sample apps. |
...-Java/app/src/main/java/com/tokbox/sample/basicvideocapturercamera2/MirrorVideoCapturer.java
Outdated
Show resolved
Hide resolved
Done |
vona-ben
requested review from
jintgeorge,
juliobecerragomez and
goncalocostamendes
v-kpheng
changed the title
What is this PR doing?
Fixes an issue where crashing may occur when toggling video
How should this be manually tested?
To reproduce, follow the steps detailed in #461
To confirm fix, checkout this branch and then follow the same steps as before 🎉