-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added multiArchiveTag to startArchive #280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things are missing:
- Add docs comments for the
multiArchiveTag
option of theOpenTok.startArchive()
method. - Add
mutliArchiveTag
as a property of theArchive
class (and add its docs). - Implement the
multiBroadcastTag
option of theOpenTok.startBroadcast()
method and themultiArchiveTag
property of the Broadcast object (and add docs for both). Or will this be a separate PR? - This PR has merge conflicts.
- Should this PR target the dev branch instead of main. Also, we need to rev the version (to 2.15.0, I think).
@jeffswartz , I was unable to find the merge conflict. Could it be that changing the base resolved it?
@jeffswartz I'm not sure where to add the property to the class. I did check for this first and did not see a need to add it since the code is composing the class props from the properties passed in: function Archive(config, properties) {
var hasProp = {}.hasOwnProperty;
var id = properties.id;
var key;
for (key in properties) {
if (hasProp.call(properties, key)) {
this[key] = properties[key];
}
}
// ... snip
} I did add the property to the docs. |
Also holding off on bumping the rev since I have another PR waiting to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as the documentation for this tag is looked out for this PR looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we also be adding the multiBroadcastTag
for start broadcast?
@jeffswartz I also added |
What is this PR doing?
This updates
startArchive
to accept in themultiArchiveTag
parameter.How should this be manually tested?
What are the relevant tickets?
DEVX-6489