Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined:session:sessionDidConnect #329

Closed
ArtyCake opened this issue Aug 16, 2019 · 6 comments
Closed

undefined:session:sessionDidConnect #329

ArtyCake opened this issue Aug 16, 2019 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@ArtyCake
Copy link

Bug Report

Current behavior
The error appears after successful connection.

Session parameters set on componentDidMount.

after the screen was displayed, UI was shown for a second and then the error appears (attached below). As it's shown in Tokbox inspector session was connected (attached screenshot)

As I can see in OTSessionManager.swift it emits next event
self.emitEvent("\(session.sessionId):\(EventUtils.sessionPreface)sessionDidConnect", data: sessionInfo);
so the sessionId at this moment became undefined somehow

Relevant logs and/or screenshots
Simulator Screen Shot - iPhone X - 2019-08-16 at 11 38 42
Screen Shot 2019-08-16 at 11 39 02 AM
Screen Shot 2019-08-16 at 11 47 59 AM

@tomek29k
Copy link
Contributor

tomek29k commented Aug 16, 2019

@ArtyCake: Can you confirm you're not wrapping <OTSubscriber> component in a <View> for example? It seems the sessionId prop is not getting through.

@ArtyCake
Copy link
Author

Interesting
Thank's for advice
I've removed <View> wrapper from <OTPublisher> and it's working
But what if I need to stylize the call screen and add more views, including wrapper around <OTPublisher> and <OTSubscriber>?

@tomek29k
Copy link
Contributor

You can use render props to custom render streams.

However, you might experience weird z-order bugs on Android with #315 and #324 – please report them if you do 🙏🏻

@ArtyCake
Copy link
Author

Thank's a lot
I will

@ggoldens ggoldens added the bug Something isn't working label Aug 16, 2019
@ggoldens
Copy link
Contributor

Thanks @ArtyCake for reporting this. We'll review this.

@ggoldens
Copy link
Contributor

ggoldens commented Sep 2, 2019

This is now fixed in v0.12.1. Closing this issue.

@ggoldens ggoldens closed this as completed Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants