Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Context API for passing props down the component tree #333

Merged
merged 4 commits into from Aug 30, 2019

Conversation

ggoldens
Copy link
Contributor

@ggoldens ggoldens commented Aug 22, 2019

Contributing checklist

  • Code must follow existing styling conventions
  • Added a descriptive commit message

In this PR we're implementing React Context API so that we don't need to pass down the sessionId as a prop on every child component.

Update (Aug 27, 2019): Also we're removing ComponentWillMount, since it's deprecated.

Solves issue(s)

#329 #335

src/OTSubscriber.js Outdated Show resolved Hide resolved
Copy link
Contributor

@enricop89 enricop89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a few comments

Copy link
Contributor

@enricop89 enricop89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@msach22 msach22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggoldens ggoldens merged commit f51e1cf into opentok:0.12.1 Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants