Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an error when updating streamId for subscriber component #326

Merged
merged 2 commits into from Aug 23, 2019
Merged

Fix an error when updating streamId for subscriber component #326

merged 2 commits into from Aug 23, 2019

Conversation

HayTran94
Copy link
Contributor

Solves issue(s)

Fix bug #315 and #324

@tomek29k
Copy link
Contributor

tomek29k commented Aug 9, 2019

Thanks for providing the fix @HayTran94.
Please can you prioritize reviewing and merging this one @msach22?

@knavu2
Copy link

knavu2 commented Aug 16, 2019

ping @msach22 @ggoldens

@HayTran94 HayTran94 mentioned this pull request Aug 21, 2019
Closed
@ggoldens ggoldens changed the base branch from master to 0.12.1 August 22, 2019 16:04
@ggoldens ggoldens self-requested a review August 22, 2019 16:04
ggoldens
ggoldens approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@ggoldens ggoldens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggoldens ggoldens merged commit c47b42e into opentok:0.12.1 Aug 23, 2019
@tomek29k
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggoldens ggoldens ggoldens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HayTran94 @tomek29k @knavu2 @ggoldens @haytran1