Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

Add documentation on how to style the publishers and subscribers #57

Closed
msach22 opened this issue Mar 4, 2019 · 5 comments
Closed

Add documentation on how to style the publishers and subscribers #57

msach22 opened this issue Mar 4, 2019 · 5 comments

Comments

@msach22
Copy link
Contributor

msach22 commented Mar 4, 2019

When creating the publishers and subscribers, the library assigns the OTPublisherContainer and OTSubscriberContainer classes to their respective DOM elements.

@michaellopez
Copy link
Contributor

@msach22
One problem is that OTPublisher and OTSubscriber have an anonymous div that can't be directly targeted with styling. See https://github.com/opentok/opentok-react/blob/master/src/OTPublisher.js#L173 and https://github.com/opentok/opentok-react/blob/master/src/OTSubscriber.js#L109
This makes it harder to use properties to set width:100%,height:100% on both OTPublisher and OTSubscriber. I'll send a PR...

@coletivo
Copy link

Whats the status on this ^? I am running into the same issues

@michaellopez
Copy link
Contributor

@coletivo This repo is basically not actively maintained. We worked around it by targeting the anonymous divs with CSS selectors

@michaellopez
Copy link
Contributor

You can see my PR here #59

@msach22
Copy link
Contributor Author

msach22 commented Mar 20, 2020

This is now solved with #59. Please use v0.10

@msach22 msach22 closed this as completed Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants