Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping room confuse camera and frustum #40

Closed
vvs- opened this issue May 27, 2015 · 5 comments
Closed

Overlapping room confuse camera and frustum #40

vvs- opened this issue May 27, 2015 · 5 comments
Milestone

Comments

@vvs-
Copy link
Contributor

vvs- commented May 27, 2015

In TR3 Lara' house there is an overlapping between room 117 and room 132 below. This produces very weird transition effects when walking or jumping.

@Lwmte
Copy link

Lwmte commented May 27, 2015

Hmm, I tested it, and it seems that everything works right (except that I can't push-pull the blocks because of faulty collision detection). When Bullet debug drawer is active (r_coll), indeed I get overlapped room geometry, but that should be filtered out considering current room.

@vvs-
Copy link
Contributor Author

vvs- commented May 27, 2015

Ok, here's the test case. Type setgamef(3,99) then setEntityPos(player,21903,33910,2560,188,0,0). When back to game play run forward. Lara should fall to room 132. Now walk left or forward a few steps then jump straight up. Lara should return to room 117.

Depending on circumstances she is able to walk over overlapping invisible roof in room 117 as if levitating.

@vvs-
Copy link
Contributor Author

vvs- commented Jun 21, 2015

Another good example is The Cistern level. Move Lara in the room with a switch 11. Jump straight up and she'll be transferred into room 10. Now roll and she instantly moved into room 9. All this without changing coordinates. And it caused big trouble in the current frustum code.

@vvs-
Copy link
Contributor Author

vvs- commented Jun 23, 2015

The camera current room and position are not coherent. It's visible in room_info where it used different room for camera sector. No matter which room it claims to show (9 or 10) it always dumps information about room 9 which is correct in the above case. Looking at the source it seems that renderer.cam->current_room is different from what sector->owner_room actually is.

@stohrendorf stohrendorf added this to the TR3 milestone Jul 1, 2015
@vvs- vvs- added the Bug label Jul 13, 2015
@vvs- vvs- changed the title Overlapping collisions conflict Overlapping room confuse camera and frustum Jul 24, 2015
Gh0stBlade added a commit that referenced this issue Aug 10, 2015
@vvs-
Copy link
Contributor Author

vvs- commented Sep 30, 2016

No more reproducible after #384.

@vvs- vvs- closed this as completed Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants