Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Levels with two character alpha numeric filename fail #2945

Closed
mosujiba opened this issue Dec 17, 2019 · 8 comments · Fixed by #3200
Closed

Levels with two character alpha numeric filename fail #2945

mosujiba opened this issue Dec 17, 2019 · 8 comments · Fixed by #3200
Labels

Comments

@mosujiba
Copy link

mosujiba commented Dec 17, 2019

Issue Summary

When loading a level from a file, the program cannot parse its name if it begins with a number. If you select such a file in the Load Level dialog or drag and drop it onto the program, the filename will simply show up blank (except for its extension). If you manually enter the filename, it will go missing when the program asks if you want to import it or load it.

Screenshot or Video Reference

opentoonz_error

System Information

  • OpenToonz Version: 1.3
  • Operating System: Windows 10
@artisteacher
Copy link
Contributor

I'm seeing the same in macOS.

@gab3d
Copy link
Contributor

gab3d commented Dec 17, 2019

It's described in the Manual as an invalid file type: here.

@mosujiba
Copy link
Author

In that case, the program should display an error message when it detects an invalid file type. It should not fail silently.

@gab3d
Copy link
Contributor

gab3d commented Dec 17, 2019

I can certainly agree with that.

@RodneyBaker
Copy link
Collaborator

RodneyBaker commented Dec 17, 2019

I agree in part although even better would be that Opentoonz be able to accept that particular filenaming as well.

The good news is that over the past year a number of filename related issues have been resolved and this is one of the remaining issue. This particular one is of interest because the filenaming convention might actually be the same as filenaming used in the xsheet; as a standard animation ordering of levels/frames might include such designations as 1a, 1b, 2A, 2B, etc.

What is perhaps most perplexing to me is how we can (via Preferences) set different file formatting syntax (via Regular Expression and yet that appears to be ignored entirely. It is hoped that in the coming 2020 development cycle we'll be able to close in on the remaining filenaming issues and resolve them as well.

Thanks @mosujiba for your report as it suggests there is still some work to be done with filenaming conventions.

@gab3d
Copy link
Contributor

gab3d commented Dec 17, 2019

Agreed; meanwhile a simple warning to the user would avoid lots of confusion.

@RodneyBaker
Copy link
Collaborator

RodneyBaker commented Dec 17, 2019

...a simple warning to the user would avoid lots of confusion.

Yes, here are a few more thoughts toward that end:

Opentoonz should catch the exceptions to the rule and let the user know a particular file formatting is not supported. I'd suggest some additional things here but I'm not entirely sure the user set RegEx via Preferences even works at present. If it did then I'd say the simple warning would inform the user that their particular filenaming requirement that isn't supported could be supported if they assign it via RegEx in Preferences.

In short, it is my understanding that every filenaming convention should be useable as long as it has been set. The heirarchy being:

  • Filenaming expressly prohibited (an example of this was a recent change where filenames using AUX, PORT, etc reserved for Windows usage throw an exception and informs the user of the prohibition)

  • Preferred filenaming format (this for optimal efficiency and workflow)

  • Expressly allowed filenaming (this for customization... example: Digital Videos StoryPlanner default file formatting not being recognized. This for optimal compatibility with other programs designed into Opentoonz)

  • User extended filenaming conventions via RegEx in Preferences (This to allow for customization not anticipated by default inclusion or changes to filename formatting via other application.)

  • Error message to catch exceptions to any of the above and inform the user of how to remedy the incompatibility.

@RodneyBaker
Copy link
Collaborator

RodneyBaker commented Dec 17, 2019

I will add also;

Make sure to use a recent nightly release in order to gain the latest improvements in filenaming.
Much has been improved in this since the release of v1.3 back in January. This includes resolution of crashes with trailing zeroes etc.

@RodneyBaker RodneyBaker changed the title Cannot load levels with numeric filenames Cannot load levels with alpha numeric filenames Dec 17, 2019
@RodneyBaker RodneyBaker changed the title Cannot load levels with alpha numeric filenames Levels with two character alpha numeric filename fail Dec 18, 2019
martinvanzijl added a commit to martinvanzijl/opentoonz that referenced this issue Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants