Remove unnecessary null pointer checks

[elfring]

An extra null pointer check is not needed in functions like the following.

• CPattern::null
• TTextList::Data

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[Xender]

+1, but I'd also like to remark that while checking for null pointer before delete is unnecessary, it could be a good idea to set the pointer to null after the deletion, to avoid potential use-after-free errors.

So using the code fragments from OP:
Here the pointer is set to null after deleting the pointed object.
Here it's not - although this one is in the destructor, so omitting it here is far less risky than omitting it somewhere else.

Also, using smart pointers (#39) instead of "naked" new/delete could provide even more defense against bugs.

[RodneyBaker]

Updated: This issue gets the award for being the oldest Issue reported that is still open (as of 20200329)

[RodneyBaker]

Given the years that have passed since this question was asked the answer would appear to be 'no' or 'not at this time'.
Perhaps the question can be restated.

[elfring]

• 🔮 Who would get into the development mood to adjust remaining update candidates?
• 💭 Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments?

[RodneyBaker]

• 🔮 Who would get into the development mood to adjust remaining update candidates?
• 💭 Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments?

Given the years that have passed I can't think of an appropriate candidate.

Given how many developers have looked at the code (and related concerns) a still decided to pass on the more trivial changes... important though they may be.... I can say with some assurance that interest is low. This does not suggest it always will be however as seen in the occassional PR.