-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrubbing or Playing Audio Causes Crash with Sierra [$160 awarded] #978
Comments
I've found that scrubbing directly in the x-sheet or with the viewer causes an immediate crash. There might be a slight delay in the crash if I start scrubbing slightly inward. If I have the audio column selected and try scrubbing through the combo-viewer, I can often scrub 2 times consecutively (on average) before a crash occurs at the start of the next consecutive scrubbing attempt. There is still the unfortunate audio distortion #941 - but only in audio files already linked to the scene. |
So, it's not just scrubbing that causes a crash. Playing a scene with audio through the viewer controls also causes a crash, though it is not as immediate. If preview has been toggled on in the viewer, I can play through the scene multiple times without issue. Scrubbing still causes an instant crash if preview is on. Audio does not cause a crash when rendering nor when previewing the audio itself in the top of the xsheet column. |
So I've found a thread on stack overflow for an audio program that looks like the same issue - the crash report looks the same anyway. The crash with sierra was eventually resolved by the very end of the thread. I am hopeful that this can point someone in the right direction. |
I updated an older mac to Sierra yesterday. Previously, with 10.9.5, audio did not crash. After upgrading to 10.12.4, audio started crashing. So this is definitely an incompatibility between OpenToonz and something that changed with Sierra. |
What sucks the most about this is that in another thread this same issue happened on linux and they fixed it in within the same week the bug was found. |
I'm sure that several of the developers would like to help, but since they do not have macs to troubleshoot with, there's not really anything they can do. We should probably start a bounty. |
Just wanted to report I've had the same problem for the past day or two. |
I find that opentoonz and toonz premium both crash when scrubbing audio on Mac OS Sierra 10.12.4 |
Bounty is started at https://www.bountysource.com/issues/40377945-scrubbing-or-playing-audio-causes-crash-with-sierra - @NoahTheAnimator @CatchyArtz @artfulroger Noticed a CoreAudio error today, maybe this is contributing to the issue. |
I can confirm that this still exists, just wondering how can we get more devs on the macOS side? Really wanting to see this great app become more stable but it seems we need to bring in more people/assignees! Any ideas how? |
I'm taking a look at this and seeing if I can figure something out. |
So far I have fixed the error that @artisteacher found in her screenshot and I'm checking this on another mac tomorrow. |
Wow great! We desperately need more devs on the macOS side. The best thing about Opentoonz is really its overall stability and lag free workflow which I guess is important for dealing with thousands of shots in production. Thank you turtletooth for your constant commitment to this beautiful app! |
Got it(I think). It appears to be a bug introduced in Sierra. I think they have addressed it in the Objective C apis, but I can't seem to fix it in C++, so I am rewriting the way that mac audio is implemented. |
Thank you so much! |
Done. No crashing in Sierra. No distortion on all sampled wav files (including non-16 bit files) or mp3 imported files. Aif is still another issue. |
Fixed in #1302 |
@turtleTooth Do not forget to claim your bounty! |
This works great! Thanks so much! |
Hi! So I just upgraded my home computer and now have OS X 10.12.2 (Sierra). Using the latest build, scrubbing audio now causes a crash - both in the x-sheet and the viewer. This is definitely not a problem with 10.11.4 or 10.11.6.
If I scrub from the beginning of the track, the crash is pretty instantaneous. If I scrub more from the middle the crash takes a little more time to occur. If I hide the audio columns, I can scrub the scene with no issue.
Thanks for all if the hard work you all do! Crash report is attached.
sierra_crash_audio.txt
The $160 bounty on this issue has been claimed at Bountysource.
The text was updated successfully, but these errors were encountered: