WIP: Fix for Shaders and Switch to QOpenGL

[ghost]

This is still pretty buggy, but shaders don't instantly crash OT anymore. It works, but throws a lot of assert errors.

@shun-iwasawa I have no experience doing OpenGL programming and would love some help.

[ghost]

So here's the limit of what I can find:

I keep getting a "cannot send events to objects owned by a different thread" error around lines that contain:

m_imp->m_context->create();
m_imp->m_context->makeCurrent(m_imp->m_surface);

Ignoring this doesn't crash the program. I have tried a variety of fixes but my limited knowledge of threading and/or opengl isn't able to fix the problem.

There is also a problem in the destructor of sceneviewer when trying to clear out l_proxy and l_contexts.

I am going to stop here and hope someone is able/willing to pick up the pieces since I seem to be at a dead end.

[ghost]

@blackwarthog - would you have any time to take a look at this? Having usable shaders is so close, but I can't figure out the last bit.

[blackwarthog]

At my system I've seen only warnings about wrong thread of context.

Seems you was at the right way, i just removed two other MACOSX preprocessor condiditions to call moveToThread in ShadingContext destructor and in ShadingContext::doneCurrent too:

blackwarthog@1213cfb

And I've no more warnings about context thread. I've checked it linux, please, tell me how it works at windows.

Also at windows and linux uses OpenGL 2.0 (by default) but for MacOS uses version 3.2. If some shaders requires OpenGL 3, then we may to select OpenGL 3.2 for all platforms (in function ShadingContext::Imp::format()).

[ghost]

With the new changes I get an instant crash, no assert errors or anything. It doesn't even trigger Visual Studio where it crashed. It just goes down hard.

[blackwarthog]

ok, i'll try to check it on Windows.

[blackwarthog]

I cannot test MSVC build at PC with graphics accelerator. I've tested MinGW build and it works at Win7 64 and GeForce 9600GT. You may to download it from from here: https://dev.icystar.com/downloads/OpenToonz-1.1.3-morevna-2017.08.08-3ea6d-win-64bit.exe

[blackwarthog]

May be latest changes in master affects shaders behavior. You may try to do rebase to latest master.

[ghost]

@blackwarthog I checked your build and it works on the first 6 shaders, but the blur ones cause an instant crash still. I did a build rebased with master and added your changes and if I run a release build, it works, but if I run a debug build, shader preview instantly takes OT down. I'm not sure why debug would be different than release.

Thanks for your help with this. I really appreciate it.

[shun-iwasawa]

I still do not find the way to fix the problem above, but confirmed that this PR as-is will fix the issue #1081 (crash with full screen mode on OSX) .

[artisteacher]

If this could fix all the fullscreen crashing, including #1396, that would be so amazing!

[ghost]

Closing - Updated in #1517