Middle Mouse Drag to Edit Values #1362

ghost · 2017-08-01T08:10:19Z

This is for #595

This does a number of changes:

All value fields can be middle click and dragged to change their value.
All value fields in the tool option bar that don't have a slider can have their label left-clicked on and dragged to change the value.
The function editor spreadsheet values can be ctrl + clicked and dragged to change their value. (This also works on empty cells in columns that already have at least one key. This is handy for quickly setting keys.)
Alt + click on a key in the function editor will clear they key.

I was torn on using middle mouse for everything except the function editor. I wanted the commands to be the same everywhere. The benefit of middle mouse is that it doesn't require two hands and a tablet pen button can often be set to middle mouse - making it useful for tablet users. However, middle mouse can't be used on the function editor, since it will pan the spreadsheet and that is useful functionality.

Because of this I opted for different commands for the function editor and all other value fields- trying to do what is most convenient for users. ( I realize that remembering two commands isn't convenient, but regularly using two hands for a command isn't also.)

I personally am most excited about the function editor commands as they seem to make adjusting key values and setting/clearing keys a breeze.

blurymind · 2017-08-01T08:25:36Z

Thank you! It should really help people with smaller screens. One suggestion to add to it- mid click drag + shift could change the value at smaller increments .. similar to how it is in blender

…

On 1 Aug 2017 09:10, "Jeremy Bullock" ***@***.***> wrote: This is for #595 <#595> This enables the user to middle mouse + drag on a numeric value to adjust the value. The original request was to be able to click on the label to adjust it, but the time that would take to link each label to a value field is unfeasible at the moment. Currently this is implemented on measured fields (fields designated by inches, mm, pixels etc.). I still need to add non- measured fields, which should be a simpler task. ------------------------------ You can view, comment on, or merge this pull request online at: #1362 Commit Summary - Basic Mouse Drag on Values Working File Changes - *M* toonz/sources/common/tunit/tunit.cpp <https://github.com/opentoonz/opentoonz/pull/1362/files#diff-0> (7) - *M* toonz/sources/include/tools/tooloptions.h <https://github.com/opentoonz/opentoonz/pull/1362/files#diff-1> (4) - *M* toonz/sources/include/toonzqt/doublefield.h <https://github.com/opentoonz/opentoonz/pull/1362/files#diff-2> (4) - *M* toonz/sources/include/tunit.h <https://github.com/opentoonz/opentoonz/pull/1362/files#diff-3> (1) - *M* toonz/sources/tnztools/tooloptions.cpp <https://github.com/opentoonz/opentoonz/pull/1362/files#diff-4> (16) - *M* toonz/sources/tnztools/tooloptionscontrols.cpp <https://github.com/opentoonz/opentoonz/pull/1362/files#diff-5> (206) - *M* toonz/sources/tnztools/tooloptionscontrols.h <https://github.com/opentoonz/opentoonz/pull/1362/files#diff-6> (34) - *M* toonz/sources/toonzqt/doublefield.cpp <https://github.com/opentoonz/opentoonz/pull/1362/files#diff-7> (35) Patch Links: - https://github.com/opentoonz/opentoonz/pull/1362.patch - https://github.com/opentoonz/opentoonz/pull/1362.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1362>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGMbVa8KXmmWOKXeY-sU5dFBDtr6YLiDks5sTt1ugaJpZM4OpXx9> .

artisteacher · 2017-08-01T11:18:00Z

I'm really excited to have this functionality. I do wish it was left-click and drag like Blender and Krita. I almost always just use a touchpad and am not sure it is possible to middle click and drag on a touchpad.

blurymind · 2017-08-01T11:50:40Z

We could use left click as well, it will work better with tablets too.. An alternative way to do it that would be neat for pc users is also mouse scrolling :)

…

On 1 Aug 2017 12:18, "artisteacher" ***@***.***> wrote: I'm really excited to have this functionality. I do wish it was left-click and drag like Blender and Krita. I almost always just use a touchpad and am not sure it is possible to middle click and drag on a touchpad. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1362 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGMbVTptTXgWqag60_gP6b7PozLJEAPQks5sTwlqgaJpZM4OpXx9> .

artisteacher · 2017-08-01T20:22:22Z

If left-click and drag isn't possible, scrolling would be a great solution. The addition of shift for more precision is a good idea.

blurymind · 2017-08-01T20:42:53Z

@turtleTooth it doesnt have to use labels. Click dragging on input boxes actually makes a lot sense imo

scrolling will be even better, as it is not constrained to the dimensions of the screen/tablet

ghost · 2017-08-02T05:46:10Z

Question about the function editor- I currently have it so you can ctrl+click and drag on a value in the function editor spreadsheet to change the value. (This can be used to also set keyframes on unkeyed cells as long as the column has a key.) I also set alt+click to remove keys.

So far this makes editing values much faster than double clicking and typing the value.

The question is "What should the keys be that go with the mouse move?"
Shift + Click
Ctrl + Click
Alt + Click

There needs to be some modifier because click on its own needs to be available for selecting cells, and middle mouse is used to pan the spreadsheet.

ghost · 2017-08-02T05:51:14Z

I am also working on getting label click and drag working for only the edit tool and selection tool. It's doable, but tedious. But since I also use tablets alot, it would be a nice option to have. Most other tool values have a slider. Plastic tool seems to be the only other one that doesn't - I'll look at that too.

All values will be able to do the middle mouse button as well.

ghost · 2017-08-02T17:47:50Z

First of all, thank you for your work, I don't understand everything, I don't know if it is related or not but i wanted to know 2 things

We will always be able to navigate between the different drawings , for example to navigate frame by frame, skipping 3 frames by 3 frames, etc. thanks to the mouse wheel or ctrl+mouse wheel ?

If it will be possible to change the values of the brush and geometry tools with this ? Or if I am completely off topic ?

ghost · 2017-08-03T06:22:26Z

Almost done- first post edited to include current functionality.

Todo:

Adjust drag value if the measure in a field is inches or cm.
Add better comments
Squash commits

attempt to make labels clickable Function Editor Basics Working All functionality working Updated comments

ghost · 2017-08-04T04:29:14Z

Done - man that was a lot more involved than I thought it would be.

blurymind · 2017-08-06T22:29:25Z

@turtleTooth you are on fire! Thank you. It's perfect :D

blurymind · 2017-08-06T22:31:20Z

i think ctrl would be a good default modifier, but ideally it should be configurable.
Mid click drag is perfect imo

RodneyBaker · 2017-08-07T03:26:37Z

These are great time savers.
As I click and drag my middle mouse my my fingers and brain simultaneously say, "Smooooooth." :)

Added: This will be another PR but (unless I'm missing something) there needs to be a way to get a field to return to the default value (or the last value before the field was activated.

ghost · 2017-08-07T03:28:01Z

Don't forget to try clicking the labels of the edit tool with left click, or ctrl + left click and drag on the function viewer. Lots of fun.

RodneyBaker · 2017-08-07T03:38:16Z

@turtleTooth said:
Don't forget to try clicking the labels of the edit tool with left click, or ctrl + left click and drag on the function viewer. Lots of fun.

I think I'm following all of that.
clicking
labels
labels of the edit tool
click with a left click (or ctrl click) and then drag
click and drag on function viewer
...
Okay, I think here is where I get lost.
The function viewer is the pink gnomon in the center of the canvas right?

Aside: And... I never realized we could scale the Table itself. Very interesting.

shun-iwasawa · 2017-11-15T09:11:38Z

Jenkins

shun-iwasawa · 2017-11-16T10:46:36Z

toonz/sources/toonzqt/doublefield.cpp

+
+void MeasuredDoubleLineEdit::mouseMoveEvent(QMouseEvent *e) {
+  if ((e->buttons() == Qt::MiddleButton) || m_labelClicked) {
+    m_value->modifyValue((e->x() - m_xMouse) / 2);


In some Fx there are parameters with small value range. For instance, the Opacity parameter of the Over Ino Fx has 0.0-1.0 value range. In such case middle-dragging of the field cannot get the values other than 0 and 1 for now.

How about modifying this line, adding the precision argument like as follows ?:

int precision = (m_maxValue > 100) ? 0 : ((m_maxValue > 10) ? 1 : 2); m_value->modifyValue((e->x() - m_xMouse) / 2, precision);

I once thought of referring MeasuredDoubleLineEdit::m_decimals variable but using the maximum value of the field seems to perform better.

shun-iwasawa · 2017-11-16T10:50:10Z

toonz/sources/toonzqt/doublefield.cpp

+  if ((e->buttons() == Qt::NoButton && m_mouseDragEditing) || m_labelClicked) {
+    m_xMouse   = -1;
+    m_modified = true;
+    onEditingFinished();


How about inserting clearFocus(); just below this line?

shun-iwasawa · 2017-11-16T10:56:04Z

Related to this feature, I found a crash problem when dragging the frame field in the console and modified in #1574 .
Anyway this feature is very useful. Thanks @turtleTooth !

ghost · 2017-11-16T17:35:46Z

Thanks for the review @shun-iwasawa - I made the requested changes.

shun-iwasawa · 2017-11-17T07:19:50Z

Jenkins

shun-iwasawa · 2017-11-17T10:08:01Z

toonz/sources/include/toonzqt/lineedit.h

@@ -33,6 +33,7 @@ class DVAPI LineEdit : public QLineEdit {

  bool m_isReturnPressed;
  bool m_forbiddenSpecialChars;
+  bool m_mouseDragEditing;


@turtleTooth Sorry for the late notice, but it seems that bool m_mouseDragEditing should be initialized to false here or in ctor.

ghost · 2017-11-17T14:31:12Z

Done. Thanks @shun-iwasawa

shun-iwasawa · 2017-11-20T03:25:07Z

Jenkins again

shun-iwasawa · 2017-11-20T07:26:34Z

LGTM Thank you @turtleTooth for addition !

artisteacher · 2017-11-20T15:22:12Z

I love this! It could also be helpful for text size. Just a thought, but replacing the sliders in the tool option bar with the click + drag on the label could save a lot of room in the tool option bar.

Mouse Drag to Edit Numeric Values

466d199

attempt to make labels clickable Function Editor Basics Working All functionality working Updated comments

ghost changed the title ~~WIP- Middle Mouse Drag to Edit Values~~ Middle Mouse Drag to Edit Values Aug 4, 2017

ghost mentioned this pull request Aug 6, 2017

Feature request: Value editing by mouse input in the Function Editor (and elsewhere?) #577

Closed

Fix conflicts

78763af

shun-iwasawa reviewed Nov 16, 2017

View reviewed changes

Jeremy Bullock added 2 commits November 16, 2017 09:46

Merge branch 'master' into mouse_change_value

e8e4bf0

Requested changes

52105cc

shun-iwasawa reviewed Nov 17, 2017

View reviewed changes

Requested changes

cc2cead

shun-iwasawa merged commit 7712907 into opentoonz:master Nov 20, 2017

shun-iwasawa mentioned this pull request Nov 24, 2017

Only the First Click to Select All #1596

Merged

shun-iwasawa mentioned this pull request Dec 5, 2017

Fix Animate Tool Control with Tool Options #1651

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Middle Mouse Drag to Edit Values #1362

Middle Mouse Drag to Edit Values #1362

ghost commented Aug 1, 2017 •

edited by ghost

blurymind commented Aug 1, 2017 via email

artisteacher commented Aug 1, 2017

blurymind commented Aug 1, 2017 via email

artisteacher commented Aug 1, 2017

blurymind commented Aug 1, 2017 •

edited

ghost commented Aug 2, 2017

ghost commented Aug 2, 2017

ghost commented Aug 2, 2017

ghost commented Aug 3, 2017 •

edited by ghost

ghost commented Aug 4, 2017

blurymind commented Aug 6, 2017

blurymind commented Aug 6, 2017

RodneyBaker commented Aug 7, 2017 •

edited

ghost commented Aug 7, 2017

RodneyBaker commented Aug 7, 2017

shun-iwasawa commented Nov 15, 2017

shun-iwasawa Nov 16, 2017

shun-iwasawa Nov 16, 2017

shun-iwasawa commented Nov 16, 2017

ghost commented Nov 16, 2017

shun-iwasawa commented Nov 17, 2017

shun-iwasawa Nov 17, 2017

ghost commented Nov 17, 2017

shun-iwasawa commented Nov 20, 2017

shun-iwasawa commented Nov 20, 2017

artisteacher commented Nov 20, 2017

Middle Mouse Drag to Edit Values #1362

Middle Mouse Drag to Edit Values #1362

Conversation

ghost commented Aug 1, 2017 • edited by ghost

blurymind commented Aug 1, 2017 via email

artisteacher commented Aug 1, 2017

blurymind commented Aug 1, 2017 via email

artisteacher commented Aug 1, 2017

blurymind commented Aug 1, 2017 • edited

ghost commented Aug 2, 2017

ghost commented Aug 2, 2017

ghost commented Aug 2, 2017

ghost commented Aug 3, 2017 • edited by ghost

ghost commented Aug 4, 2017

blurymind commented Aug 6, 2017

blurymind commented Aug 6, 2017

RodneyBaker commented Aug 7, 2017 • edited

ghost commented Aug 7, 2017

RodneyBaker commented Aug 7, 2017

shun-iwasawa commented Nov 15, 2017

shun-iwasawa Nov 16, 2017

Choose a reason for hiding this comment

shun-iwasawa Nov 16, 2017

Choose a reason for hiding this comment

shun-iwasawa commented Nov 16, 2017

ghost commented Nov 16, 2017

shun-iwasawa commented Nov 17, 2017

shun-iwasawa Nov 17, 2017

Choose a reason for hiding this comment

ghost commented Nov 17, 2017

shun-iwasawa commented Nov 20, 2017

shun-iwasawa commented Nov 20, 2017

artisteacher commented Nov 20, 2017

ghost commented Aug 1, 2017 •

edited by ghost

blurymind commented Aug 1, 2017 •

edited

ghost commented Aug 3, 2017 •

edited by ghost

RodneyBaker commented Aug 7, 2017 •

edited