New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Fx: Bokeh Ref Iwa #1555
New Fx: Bokeh Ref Iwa #1555
Conversation
74744a6
to
a4c27d8
Compare
Jenkins |
@shun-iwasawa Could you provide a test scene or settings for this? I have tried testing this and keep getting a white screen or a distorted image. I'm sure it's an error on my side, but I can't quite figure it out. By the way - is this supposed to be very ram intensive. There were times that on a single 1920 x 1080 image this was using 2GB of ram. |
@turtleTooth Thank you for trying this fx. Here is my configuration: In your scene, please try setting the
Sorry to say, Yes. With 1920x1080 camera size it will allocate about 350MB of memories just for raster buffers used in this fx. Could you please try smaller camera and check if the scene can be rendered? |
Took a look at this again today. I am getting an index out of range error. Here is my setup: All columns exposed for 1 frame. When I go to preview the fx, I get a crash. Edit- The raster level had transparent pixels. Painting the empty pixels white stopped the crash. |
@shun-iwasawa I still can't get good results with this. I get either no noticeable effect or a white screen. Here is my setup: |
@turtleTooth If you will still unable to render, can you please upload all the materials including the depth and iris images and the scene to reproduce on my side ? |
@turtleTooth This is another sample data which can be rendered on my environment. Please put the level files into |
Thanks @shun-iwasawa - I was able to get it working with my tree scene. It's always something simple. Is there any benefit in letting hardness go as high as it does? I also think that fixing the crash on transparent images would be good, but can wait for a later time. |
@turtleTooth For the depth image this Fx uses its brightness as well. With the depth image with only transparent and black pixels the Fx will fail to compute anymore since the brightness is 0 at all pixels of the depth image. |
By having the large value of |
Makes sense. If you would like to save the crash fix for later, you can go ahead and merge this. I got it working and LGTM. Thanks for this- it's a pretty cool effect. |
@turtleTooth Can you please merge this first? I'll push the fix in another PR soon. Thanks! |
Oh, I was overlooking it. Then I'll merge this. Again, thank you @turtleTooth for reviewing. |
Post mortem pondering of how to best use the Bokeh and Boken Ref FX... Here's an article that discusses some use of Bokeh. |
This PR will introduce a new Fx named Bokeh Ref Iwa, for defocusing a single image by using a "depth reference image".
Most of specification is very similar to the Bokeh Iwa fx (implemented in PR #1123 ), except as follows:
By changing the on-focus distance, you can obtain racking focus shot from one deep-focused photo like this: