Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish UI - update to latest Japanese .ts files #1593

Merged
merged 31 commits into from Nov 24, 2017
Merged

Spanish UI - update to latest Japanese .ts files #1593

merged 31 commits into from Nov 24, 2017

Conversation

gab3d
Copy link
Contributor

@gab3d gab3d commented Nov 23, 2017

Spanish UI - update to latest Japanese .ts files
There are still some untranslatable strings...

gab3d added 30 commits July 24, 2017 19:58
Still there are some strings untranslatable.
@shun-iwasawa
Copy link
Member

LGTM Thank you @gab3d . I didn't know that RGB is translated as RVA in Spanish.

For the future PR, I must beg of you to create a new branch from the current master and just commit the latest translation. Here are some instructions:

  • Add upstream repository that will be synced with the original repo. (Do once if you have not added yet.)

$ git remote add upstream https://github.com/opentoonz/opentoonz.git

  • Synchronize your master (local master branch) and origin/master (remote master branch) to the current upstream.
$ git checkout master
$ git pull upstream master
$ git push origin master
  • Create a new branch for translation work (For example, named nice_branch_name ).

$ git checkout -b nice_branch_name master

  • Do translation work on the branch nice_branch_name and then commit changes.
$ git add path_to_translation_file.ts
$ git commit

or
$ git commit -a

  • Push your branch.

$ git push origin nice_branch_name

  • Go to github site and make a new PR.

@shun-iwasawa shun-iwasawa merged commit fb16291 into opentoonz:master Nov 24, 2017
@gab3d gab3d deleted the spanish branch November 28, 2017 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants