Resolve Warnings in Timeline View #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins |
|
Nice. Was annoyed by those messages when I was qDebugging stuff and couldn't figure out what was generating that message so I could disable it. |
|
LGTM. Thanks @shun-iwasawa |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor PR.
In my environment of MSVC2015, many lines of warning saying
QPainter::begin: Paint device returned engine == 0, type: 2appears in the console while displaying the Timeline.For now Timeline has no thumbnails. The warning appears when OT tries to scale the thumbnail to invalid (=empty) size.