Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will refactor sources and resource images in order to resolve all warnings appears on launching the software with console.
Here is a list of resolved warnings:
Removed
signal updateVisibility()
fromXSheetToolbar
class definition as it is already defined in the base classCommandBar
. Also removedbool m_isCollapsible;
variable for the same reason.Made
XsheetViewer::positionSections()
to be executed only if the Xsheet panel is visible, since this function seems to be needed to be called only from showEvent and resizeEvent.Made a new private function
StyleEditor::createVectorPage()
in order to make the ctor ofStyleEditor
cleaner. Made the sub-layouts to be constructed without parent widget pointer in order to avoid resetting of the parent widget.Removed
&:extend(.tab-container all);
from claimed objects in style sheets as they are not used.Applied lossless file optimization to all resource PNG images in order to remove sRGB information (which may be added by PhotoShop). I used FileOptimizer by Javier Guti茅rrez Chamorro. It could reduce the file size as well. 馃憤
Please note that the second commit (
optimize png files
) in this PR is dedicated to this.