Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Warnings on Launch #1745

Merged
merged 2 commits into from Feb 19, 2018

Conversation

shun-iwasawa
Copy link
Member

@shun-iwasawa shun-iwasawa commented Jan 19, 2018

This PR will refactor sources and resource images in order to resolve all warnings appears on launching the software with console.

Here is a list of resolved warnings:

QMetaObject::indexOfSignal: signal updateVisibility() from CommandBar redefined

Removed signal updateVisibility() from XSheetToolbar class definition as it is already defined in the base class CommandBar. Also removed bool m_isCollapsible; variable for the same reason.

in XsheetGUI::XSheetToolbar
QWidget::setMinimumSize: (XSheetToolbar/XsheetGUI::XSheetToolbar) Negative sizes (-5,30) are not possible

Made XsheetViewer::positionSections() to be executed only if the Xsheet panel is visible, since this function seems to be needed to be called only from showEvent and resizeEvent.

QLayout: Attempting to add QLayout "" to StyleEditor "", which already has a layout

Made a new private function StyleEditor::createVectorPage() in order to make the ctor of StyleEditor cleaner. Made the sub-layouts to be constructed without parent widget pointer in order to avoid resetting of the parent widget.

PaletteViewerGUI::PaletteTabBar(0xc6d6d50, name="PaletteTabBar") does not have a property named "BottomAboveLineColor"
DVGui::TabBar(0xc51b240, name="StyleEditorTabBar") does not have a property named "BottomAboveLineColor"

Removed &:extend(.tab-container all); from claimed objects in style sheets as they are not used.

libpng warning: iCCP: known incorrect sRGB profile

Applied lossless file optimization to all resource PNG images in order to remove sRGB information (which may be added by PhotoShop). I used FileOptimizer by Javier Guti茅rrez Chamorro. It could reduce the file size as well. 馃憤
Please note that the second commit ( optimize png files ) in this PR is dedicated to this.

@shun-iwasawa
Copy link
Member Author

Jenkins

@shun-iwasawa
Copy link
Member Author

Jenkins again

@masafumi-inoue
Copy link
Contributor

LGTM

@masafumi-inoue masafumi-inoue merged commit dfea21b into opentoonz:master Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants