Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deletes with some refactoring #190

Merged
merged 14 commits into from
Apr 20, 2016
Merged

Remove deletes with some refactoring #190

merged 14 commits into from
Apr 20, 2016

Conversation

skitaoka
Copy link
Member

@skitaoka skitaoka commented Apr 18, 2016 •
edited
Loading

  • remove delete
  • remove delete[]
  • use _WIN32 instead of WIN32
  • remove register keywords
  • remove using namespace std; from headers
  • remove using namespace DVGui; from headers

This PR contains modifications of PR #176

@skitaoka skitaoka changed the title [WIP] Remove deletes by using smart pointers Remove deletes with some refactoring Apr 18, 2016
@kogaki
Copy link
Member

kogaki commented Apr 18, 2016

Jenkins

@skitaoka
Copy link
Member Author

Jenkins, test this

@tomosu
Copy link
Contributor

tomosu commented Apr 20, 2016

LGTM

@tomosu tomosu merged commit b8c01c1 into opentoonz:master Apr 20, 2016
@skitaoka skitaoka deleted the fix/delete-deletes branch April 21, 2016 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skitaoka @kogaki @tomosu