Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving mesh levels problem + Modify style sheet for mesh columns #207

Merged
merged 4 commits into from
Apr 20, 2016

Conversation

shun-iwasawa
Copy link
Member

This fix is for resolving the issue #124
Also modifying style sheets suitable for displaying mesh columns in xsheet for each style.

@shun-iwasawa
Copy link
Member Author

Jenkins, test this

@kogaki
Copy link
Member

kogaki commented Apr 20, 2016

It works on my OSX. LGTM.

@kogaki kogaki merged commit 7f1cbfc into opentoonz:master Apr 20, 2016
@blurymind
Copy link

blurymind commented Apr 20, 2016

It still crashes on windows 7.

file > 'save level as' leads to crash
file> 'save level' (with any tool active) you cannot save this level message

using nightly 7f1cbfc
https://github.com/opentoonz/opentoonz/releases/tag/nightly

@kogaki
Copy link
Member

kogaki commented Apr 20, 2016

@blurymind Sorry for confusing announce, but nightly build for windows was updated just a few minutes ago. Could you try latest one?

This is because build for windows takes longer than that for OSX and commit number was updated when that for OSX finished.

@blurymind
Copy link

blurymind commented Apr 20, 2016

@kogaki Ah I see. No worries. After reinstalling again I can confirm that mesh saving works on windows7 now!

@shun-iwasawa Awesome! Thank you kindly. I will test this more throughly soon.

@kogaki
Copy link
Member

kogaki commented Apr 20, 2016

Good!

@blurymind
Copy link

blurymind commented Apr 20, 2016

@shun-iwasawa unfortunately this seems to introduce a new bug:
Once you make a mesh, you can not exit the mesh level.
As a result opentoonz gets locked in the plastic tool completely.

to reproduce:

  1. create a mesh level
  2. select the raster or vector level that the mesh level is using (via x-sheet or schematic view)
  3. select the brush tool and try to draw on the canvas

as a result any level that is controlled by a mesh can not be edited - this wasnt the case in the previous version. It's much harder to work this way.

@blurymind
Copy link

blurymind commented Apr 20, 2016

@shun-iwasawa appologies - this is not a regression - the previous versions of opentoonz had this issue too. It is not a bug , but a limitation of the software.

The patch fixes saving and does not break anything

@Rayek
Copy link

Rayek commented Apr 20, 2016

@blurymind: the mesh-controlled level can still be edited when you click the thumbnail in the level strip.

@blurymind
Copy link

blurymind commented Apr 20, 2016

@Rayek I found out about it a week ago, then totally forgot and thought this is a bug again.
It just feels counter-intuitive to no longer be able to access the current frame active drawing through level when there is a mesh applied. I guess that this limitation would stop some technical problems from occurring at least.

There are slight limitations:

  • You cant draw directly on the deformed by a mesh level - while the deformation effect is visible
  • if you have attached more than one levels to the same mesh, you can not see the others while you make changes to one of them.

I guess that when the level is warped by a mesh, it's coordinate space becomes warped, so if the user tries to edit it through the warp, the software has trouble translating where the cursor is.
I have no idea how toonboom does it.

I can still live without it.
There are more important features and fixes which the developers are working on.
@Rayek With the mesh level -am I the only one who has this bug: #134
I tested it on two laptops - one with nvidia and another with ati video card

@Rayek
Copy link

Rayek commented Apr 20, 2016

@blurymind As far as I can tell, once you apply a mesh, the drawing is converted to a texture (you can test this by moving the content: notice the black background surrounding the image).

Here is a nice workflow:

  • create your object/character which will be deformed later with a mesh. Use as many columns (layers) as you like.
  • save all levels, and save the scene. For example, "character".
  • then create a new scene, and select the frame you would like to import the character. Then choose :Load Level".

This will load the entire character scene as a subsheet.in your x-sheet. It is also possible to just drag a scene from the file browser into your x-sheet frame(s).

  • now apply a mesh, and start animating with mesh deformation.
  • if you wish to make a colour change, or edit the character content, just right-mouse click on the column header title, and open the sub sheet. When you have finished with edits, close the sub sheet again.

This is a very powerful workflow. You can really tell that OT has "studio production" written all over it.

@blurymind
Copy link

blurymind commented Apr 21, 2016

@Rayek the black background surrounding the mesh is a nasty regression bug. Toonz harlequin didnt have that problem.
It's a bug - not a feature or design.
I explained how it can hinder workflow in my bug report #134

This is in toonz harlequin:
blackbgregressionmesh

This is opentoonz
opentoonz-glithch

@shun-iwasawa shun-iwasawa deleted the fix_save_mesh branch December 1, 2016 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants