-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix saving mesh levels problem + Modify style sheet for mesh columns #207
Conversation
Jenkins, test this |
It works on my OSX. LGTM. |
It still crashes on windows 7. file > 'save level as' leads to crash using nightly 7f1cbfc |
@blurymind Sorry for confusing announce, but nightly build for windows was updated just a few minutes ago. Could you try latest one? This is because build for windows takes longer than that for OSX and commit number was updated when that for OSX finished. |
@kogaki Ah I see. No worries. After reinstalling again I can confirm that mesh saving works on windows7 now! @shun-iwasawa Awesome! Thank you kindly. I will test this more throughly soon. |
Good! |
@shun-iwasawa unfortunately this seems to introduce a new bug: to reproduce:
as a result any level that is controlled by a mesh can not be edited - this wasnt the case in the previous version. It's much harder to work this way. |
@shun-iwasawa appologies - this is not a regression - the previous versions of opentoonz had this issue too. It is not a bug , but a limitation of the software. The patch fixes saving and does not break anything |
@blurymind: the mesh-controlled level can still be edited when you click the thumbnail in the level strip. |
@Rayek I found out about it a week ago, then totally forgot and thought this is a bug again. There are slight limitations:
I guess that when the level is warped by a mesh, it's coordinate space becomes warped, so if the user tries to edit it through the warp, the software has trouble translating where the cursor is. I can still live without it. |
@blurymind As far as I can tell, once you apply a mesh, the drawing is converted to a texture (you can test this by moving the content: notice the black background surrounding the image). Here is a nice workflow:
This will load the entire character scene as a subsheet.in your x-sheet. It is also possible to just drag a scene from the file browser into your x-sheet frame(s).
This is a very powerful workflow. You can really tell that OT has "studio production" written all over it. |
This fix is for resolving the issue #124
Also modifying style sheets suitable for displaying mesh columns in xsheet for each style.