New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) Fix Vector Flipping on Using Tape Tool #2355
base: master
Are you sure you want to change the base?
(WIP) Fix Vector Flipping on Using Tape Tool #2355
Conversation
Jenkins |
This PR has passed all tests and appears to be ready to merge. I'm doublechecking the WIP aspects of this. |
I agree that this is WIP concerning Fills. The added ability to maintain the vector order however is very much on target. |
@RodneyBaker OK, so let's postpone the inclusion of this. Thank you for your checking! |
Tagged as 'roadmap' and moved to 2019 development cycle. Note for those in need of this update as a partial fix: Direct Link to developmental build download: (WIP) Fix Vector Flipping on Using Tape Tool |
Closing temporarily. Will reopen in 2019 development cycle. |
@shun-iwasawa I'm reopening this PR as it found some renewed interest via chat on discord. |
This will fix #2347
This is WIP, as I think this fix is need to be evaluated regarding the following behavior:
When applying the tape tool with "Join Vectors" and "Smooth" options being on, if the target stroke is a part of some filled region, the result sometimes causes unexpected change of styles used for filling (i.e. the fill color sometimes changes).
I'm not sure if it is acceptable for users, since the current OT already have such behavior when modifying vector strokes.