Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Fix Vector Flipping on Using Tape Tool #2355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shun-iwasawa
Copy link
Member

This will fix #2347
This is WIP, as I think this fix is need to be evaluated regarding the following behavior:
When applying the tape tool with "Join Vectors" and "Smooth" options being on, if the target stroke is a part of some filled region, the result sometimes causes unexpected change of styles used for filling (i.e. the fill color sometimes changes).

I'm not sure if it is acceptable for users, since the current OT already have such behavior when modifying vector strokes.

@shun-iwasawa
Copy link
Member Author

Jenkins

@shun-iwasawa shun-iwasawa changed the title [WIP] Fix Vector Flipping on Using Tape Tool Fix Vector Flipping on Using Tape Tool Dec 14, 2018
@RodneyBaker
Copy link
Collaborator

RodneyBaker commented Dec 17, 2018

This PR has passed all tests and appears to be ready to merge.
@shun-iwasawa If this is something I can merge I'd be happy to do it.

I'm doublechecking the WIP aspects of this.
I do confirm this PR fixes the reported issue.

@RodneyBaker RodneyBaker changed the title Fix Vector Flipping on Using Tape Tool (WIP) Fix Vector Flipping on Using Tape Tool Dec 17, 2018
@RodneyBaker
Copy link
Collaborator

I agree that this is WIP concerning Fills.
The primary workaround for fills would be to perform the Fill as a step independent of the auto-inbetween.

The added ability to maintain the vector order however is very much on target.

@shun-iwasawa
Copy link
Member Author

@RodneyBaker OK, so let's postpone the inclusion of this. Thank you for your checking!

@RodneyBaker
Copy link
Collaborator

RodneyBaker commented Dec 18, 2018

Tagged as 'roadmap' and moved to 2019 development cycle.

Note for those in need of this update as a partial fix:
Appveyor releases contains this fix and are available for six months from the time of the appveyor build. This presents users with an option to use the stated fix/enhancement/feature in addition to the official release. As with any developmental build use at own risk and back up important files first before use. For more information on appveyor builds see: LINK

Direct Link to developmental build download: (WIP) Fix Vector Flipping on Using Tape Tool

@RodneyBaker
Copy link
Collaborator

Closing temporarily. Will reopen in 2019 development cycle.

@RodneyBaker
Copy link
Collaborator

@shun-iwasawa I'm reopening this PR as it found some renewed interest via chat on discord.
Not sure of status but at least the issue can be reviewed and discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using the "Tape Tool" changes the direction of the vector.
2 participants