Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next/prev keyframe shortcuts #2734

Merged
merged 3 commits into from Oct 19, 2019

Conversation

manongjohn
Copy link
Collaborator

Requested on Google forum, this PR adds shortcuts for keyframe navigation controls, Next Key and Prev Key.

The behavior of the shortcut keys changes based on the panel/window you are focused on, coinciding with how the keyframe navigation controls works on that panel:

When focused on...

  • Scene/Combo Viewers - Moves between keyframes on the current level in Xsheet/Timeline
  • Function Editor - Moves between keyframes in the Function Editor
  • Level/Studio Palettes - Moves between color keyframes in either Xsheet/Timeline or Level Strip.
  • Fx Settings - Moves between Fx keyframes

All other panels without a keyframe navigation control will use the Scene/Combo Viewer logic.

@beeheemooth
Copy link

@manongjohn Thank you very much for this feature, and for listening to user requests !

@gab3d
Copy link
Contributor

gab3d commented Sep 7, 2019

Sorry to ask, but will there be default shortcuts assigned to them?
It would be nice.

What do other people think?

@manongjohn
Copy link
Collaborator Author

I was using CTRL+, (prev) and CTRL+. (Next). Basically the Prev/Next Drawing shortcuts with CTRL.

What do other software use, if they have similar keys?

@gab3d
Copy link
Contributor

gab3d commented Sep 8, 2019

All main applications use a variant of the Previous/Next Frame shortcuts.
It seems good to me. 👍

@RodneyBaker RodneyBaker added this to 2019 Development in 2020 UI Scrub via automation Sep 21, 2019
2020 UI Scrub automation moved this from 2019 Development to Completed Oct 18, 2019
@RodneyBaker RodneyBaker reopened this Oct 18, 2019
2020 UI Scrub automation moved this from Completed to 2019 Development Oct 18, 2019
@RodneyBaker
Copy link
Collaborator

LGTM
Very useful addition.
Thanks @manongjohn

@RodneyBaker RodneyBaker merged commit 011361b into opentoonz:master Oct 19, 2019
2020 UI Scrub automation moved this from 2019 Development to Completed Oct 19, 2019
@manongjohn manongjohn deleted the keyframe_shortcuts branch November 2, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2020 UI Scrub
  
Completed
Development

Successfully merging this pull request may close these issues.

None yet

4 participants