Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Assertion Failure on Selecting Camera Column #2810

Merged

Conversation

shun-iwasawa
Copy link
Member

This PR will resolve assertion failure occurs with the following steps in debug mode:

  1. Select Animate tool.
  2. Select camera column.

The assertion failure occurs at line 212 of tstageobject.cpp ;

const TStageObjectId TStageObjectId::ColumnId(int index) {
  assert(0 <= index && index <= StageObjectMaxIndex);
  return TStageObjectId(COLUMN << StageObjectTypeShift | index);
}

There were cases that the function TStageObjectId::ColumnId() is called with the argument index being -1 when the camera column is selected.

@RodneyBaker
Copy link
Collaborator

LGTM

@RodneyBaker RodneyBaker merged commit eb04b70 into opentoonz:master Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants