Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Type Tool Cursor Jumping #2874

Merged
1 commit merged into from Nov 14, 2019

Conversation

shun-iwasawa
Copy link
Member

This PR fixes a following problem of Type Tool when inputting text with non-Latin alphabets such as Japanese.

  • While typing the text, pressing the Shift key unexpectedly moves the cursor to the beginning.

In the type tool QInputMethodEvent is used only when typing non-latin alphabets. TypeTool::m_preeditRange specifies the location where the text to be inserted.
Pressing the Shift key reset the location (at line 1534) before going out of the function, which was the cause of the problem.

@RodneyBaker
Copy link
Collaborator

@shun-iwasawa All appears to be in order.
I'm not sure how thoroughly I can test non-latin alphabets without adjusting my operating system to fully test however. I can press into that if necessary.
Otherwise, recommend merging this PR yourself at your own discretion.

@ghost
Copy link

ghost commented Nov 14, 2019

LGTM.

@ghost ghost merged commit b224639 into opentoonz:master Nov 14, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants