Port to vs2015 #307
Closed
Port to vs2015 #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded a second function std::map::count and bind couldn't resolve the function. Substituted with a lambda-expression.
…ot finished, panel is wrong now (also uses CleanupSettings).
|
How about #69 ? |
|
I am absolutely for it, it takes ages to upload the built binaries and having them everywhere is terrible. But I don't think I am able to do this currently. I would prefer to wait until it is fixed here and then also fix my branch. I will comment in #69. |
…n resolutions. Used the same value (PERCENT * max dot size) as later in the code in compare_dots.
… fit and used that. The problem was, that the middle hole was used as center for auto center. For three peg holes that is correct, but does not work for more than three. Now the best fit is calculated and from there the offset of the middle of the three best fit holes is calculated and applied.
|
Josef- |
|
I use the target |
|
This PR was merged by #544. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have ported opentoonz to VS 2015. It will probably not make sense at this time to move to it, but there are two commits, the first are only source changes which should be portable and the second one are all the binaries. I only built the 64bit variants of the files (release and debug).
The source changes are rather small, I had to remove
cprintfin openblas, VS 2015 for some reason didn't link with it defined, so nowprintfis used instead. The other change was intoonz/sources/toonz/cleanuppopup.cpp, Microsoft for some reason decided to add a second set ofcountfunctions into containers so bind didn't resolve it. I substituted it with a small lambda.Building QT is rather straight forward, only the OpenGL-setting has to be changed to
desktop, I had no luck with the default setting ofdynamic, it caused collisions between GLEW and QtGL. And you need ICU (forget the web pages saying differently), UIC doesn't compile without.