Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preproduction Board feature 1.6 #4611

Merged
merged 28 commits into from Dec 6, 2022
Merged

Preproduction Board feature 1.6 #4611

merged 28 commits into from Dec 6, 2022

Conversation

flurick
Copy link
Contributor

@flurick flurick commented Nov 24, 2022

Rebased #3665 and slightly tweaked according to those comments

@RodneyBaker
Copy link
Collaborator

Thanks much for this @flurick
Very much appreciated.
Initial testing... looking good.

The only problem I've ran into thus far is the Preproduction Board entry disappearing from the Windows menu.
Restarting the program didn't bring it back... odd.
The option to assign a shortcut key to Production Board window was still present so I'm using that to open the window.

@konero
Copy link
Contributor

konero commented Nov 25, 2022

My feedback for what it's worth (I know you're not the original developer, there's no issue I can post this to, so don't worry about it).

  1. Bigger thumbnails
  2. Change the transparent backdrop for the thumbnail to white
  3. Remove the clapperboard stripes, since this panel only displays scenes

@ghost
Copy link

ghost commented Nov 25, 2022

@flurick First of all, thank you for developing this feature, it was really one of the few work steps that could not be done in OT, it would be great to be able to do almost everything in OT.

If I may say so, here are my feelings. Of course you are free to think that it is not immediately related to this request.

While testing this PR, I was frustrated with the scene save pop up that kept appearing, and gives a rather different experience than in other software with stroyboarding.

So I see this panel more as a way to facilitate access to the scenes and play them. And I was wondering if we couldn't have some level strip features to complete, and (from my point of view) improve the experience.

Here are some suggestions in that direction:

  • Allow different level strip thumbnail sizes per room.

I tested the PR by creating a room with a level strip with a larger thumbnail size (from the interface tab in the preferences). But it would be better if you could choose the size individually for each room.

  • Allow shortcuts or buttons to add frames before and after the one selected. Currently the insert key does not allow to choose the direction of adding the frame. And the add frames command neither. Below is an example from (the storyboard function of krita) (plus button on thumbnail). Or alternatively elsewhere on the level strip.

story ot

Like @konero, it would be nice to be able to change the size of the thumbnails of the scenes (like with the level strip). By the way you can choose the color you want of the thumbnails from the menu Xsheet => scene setting => camera BG => full alpha. In my suggestion, howover I am in favor of keeping the scene strips to differentiate them from the level strip and be able to know u can click on play icon on them.

@artisteacher
Copy link
Contributor

As far as the level strip size goes, it really should be responsive. So when you make the level strip taller/shorter (horizontal orientation) or wider/narrower (vertical orientation), the icons automatically grow/shrink to fill the available space. There shouldn't be a hardcoded size. Then it would easily work on a room by room basis.

@RodneyBaker RodneyBaker marked this pull request as ready for review November 30, 2022 21:24
@ghost
Copy link

ghost commented Dec 1, 2022

In the level folders for the raster levels when you use transparent background. They appear full transparent instead of having the checkerboard transparency. So for example you can't see the format used (like portrait or landscape).

Or maybe we could have also for the browser window the 3 colour option (or 4 here) available on the viewer and flipbook window, to switch between the different colour states ?

@RodneyBaker
Copy link
Collaborator

I know there are lots of plans and hopes for the Production Board moving forward but I want to post my intent to merge this PR in order to finally have closure on the initial Production Board which only had a few small things keeping it from moving forward. With those now resolved thanks to @flurick, @morevnaproject's original contribution can be added and additional changes can start to be added as they become available.

Please let me know of any reason to delay this initial feature addition any further.
Thanks!

@morevnaproject
Copy link
Contributor

@flurick Thanks for taking on this PR. Will be happy to see it merged! ^__^

@RodneyBaker
Copy link
Collaborator

And... merge time.

Thank you @flurick for moving the Preproduction Board to this finish line.
Thank you @morevnaproject for setting it in motion.
I'm confident that in time it will be even more useful.

Aside: We'll have to find a good place to maintain suggestions/links to those things that testers provided feedback on.
In the meantime there are certainly the PRs themselves.

@RodneyBaker RodneyBaker merged commit f581460 into opentoonz:master Dec 6, 2022
@RodneyBaker RodneyBaker mentioned this pull request Dec 6, 2022
9 tasks
@morevnaproject
Copy link
Contributor

Aside: We'll have to find a good place to maintain suggestions/links to those things that testers provided feedback on.
In the meantime there are certainly the PRs themselves.

Many open-source projects use GitHub issues for feature requests and suggestions. Those issues are just have special tag (i.e. "feature request") to separate them from regular bugs.
When PR is merged and some suggestion remain, those suggestions are submitted as separate issues to be addressed later. This is very helpful for project management.

@RodneyBaker
Copy link
Collaborator

So very nice to have this feature finally in Opentoonz.

image

@RodneyBaker
Copy link
Collaborator

I believe most users will need a clean install of their stuff directory in order to see the Preproduction Board option appear in the menu.

@flurick flurick deleted the board branch December 7, 2022 09:20
@RodneyBaker
Copy link
Collaborator

The disappearance of the Production Board option from the menu observed during testing appears to also be in the nightly releases. I am unsure why the option isn't persistent but am starting to see reports of this so thought this notice would be appropriate.

The option does appear initially after installation.

@flurick
Copy link
Contributor Author

flurick commented Dec 12, 2022

Yeah, looks like MI_OpenPreproductionBoard needs to be added to the menubar.xml and the different menubar_template.xml's in stuff?

RodneyBaker added a commit that referenced this pull request Dec 13, 2022
@RodneyBaker RodneyBaker mentioned this pull request Mar 18, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants