Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste external clipboard images #4681

Merged
merged 1 commit into from Jan 1, 2023
Merged

Paste external clipboard images #4681

merged 1 commit into from Jan 1, 2023

Conversation

justburner
Copy link
Contributor

@justburner justburner commented Dec 29, 2022

This is a Tahoma2D port with the following changes:

  • Pasting on a Raster level cell or the empty X cell in front will automatically paste in the center instead of nagging the user by always asking if want to Paste in place or Create new level on each paste.
  • Attempting to paste on non Raster level cell or empty column/location will ask the user if wants to create a new level instead of creating a new level automatically without user's consent, this is to avoid polluting the project with extra files as undo does not delete them.

More information about the T2D implementation:

  • External images do require Raster level.
  • Selection Tool must be active to be able to control and transform the pasted image, otherwise the image will be instantly pasted in the center.
  • If the image is bigger than the level canvas then the paste will be scaled down to fit the canvas.

Resolves #3503

T2D port with some changes

Co-Authored-By: jeremybullock <79284068+jeremybullock@users.noreply.github.com>
@RodneyBaker
Copy link
Collaborator

Happy new year to all!
Posting intent to merge this PR later today.

@RodneyBaker
Copy link
Collaborator

RodneyBaker commented Jan 1, 2023

Thank you @justburner for the port of copy/paste from Tahoma2D and for additonal adjustments.
Thank you @jeremybullock for the original implementation!

Added Developmental Trivia: This PR is the 2000th closed Pull Request
image

@RodneyBaker RodneyBaker merged commit d2c95a8 into opentoonz:master Jan 1, 2023
@F-Burning
Copy link

F-Burning commented Jan 1, 2023

Thank you so much!

A suggestion is don't crop or resize the image, because if you have to re-scale the raster after the resize, lose a lot quality, and when a picutre is large in horizontal at least, it's cropped and lost information too.

Happy new year! 🎊 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy/Paste from external programs
3 participants