Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #507

Merged
merged 2 commits into from
Jun 24, 2016
Merged

Fixes #507

merged 2 commits into from
Jun 24, 2016

Conversation

janisozaur
Copy link
Contributor

No description provided.

@janisozaur
Copy link
Contributor Author

std::max_element: http://ideone.com/SQV86b

@janisozaur janisozaur mentioned this pull request Jun 23, 2016
Merged
@janisozaur
isnan fix
a92a714 
isnan is already defined on Linux in math.h, as included in:

    toonz/sources/include/tutil.h:7,
    toonz/sources/include/traster.h:6,
    toonz/sources/include/tcolorutils.h:9,
    toonz/sources/common/tapptools/tcolorutils.cpp:4:

with type:

    constexpr bool std::isnan(double)
@janisozaur
Use std::max_element
a6309b1
@skitaoka
Copy link
Member

Jenkins, test this.

@janisozaur janisozaur mentioned this pull request Jun 24, 2016
Merged
@ideasman42
Copy link
Collaborator

These could be separate PR's, also would be good to use less vague title.

@skitaoka
Copy link
Member

skitaoka commented Jun 24, 2016 •
edited
Loading

I'm merging this, because there are no problems to implement functions; however I also prefer that single PR with understandable title undo contains modifications for single issue.

@skitaoka skitaoka merged commit 3f703d2 into opentoonz:master Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janisozaur @skitaoka @ideasman42