Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated rooms for consistency #584

Merged
merged 5 commits into from Aug 4, 2016
Merged

Updated rooms for consistency #584

merged 5 commits into from Aug 4, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2016

This provides more room for the tool bar and tool options bar. Fix for #583

@blurymind
Copy link

Can you make a screenshot :)

@ghost
Copy link
Author

ghost commented Jul 7, 2016

Of course.

new_basics

And smaller:
new_basics_small

Before, the tool option bar didn't go all the way across, which works fine for large displays, but on smaller displays, you lose visibility of some options.

In fact, I just checked the other rooms, and it's inconsistent. I think I will update the other rooms for consistency.

@blurymind
Copy link

It would be amazing if we could get more space for those sliders in the
options bar. Why are the drop down lists before "miter" eating up so much
horizontal space. This is madness xD
On 7 Jul 2016 03:07, "turtletooth" notifications@github.com wrote:

Of course.

[image: new_basics]
https://cloud.githubusercontent.com/assets/4576381/16640388/d5b36ae0-43b4-11e6-8c4b-976696cc732f.png

And smaller:
[image: new_basics_small]
https://cloud.githubusercontent.com/assets/4576381/16640394/dd8af2f6-43b4-11e6-9591-b42a7ef0ed30.png

Before, the tool option bar didn't go all the way across, which works fine
for large displays, but on smaller displays, you lose visibility of some
options.

In fact, I just checked the other rooms, and it's inconsistent. I think I
will update the other rooms for consistency.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#584 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGMbVaHRRvvev7R9Q5OZoWzSm9e8p4djks5qTF9EgaJpZM4JFt8g
.

@ghost ghost changed the title Updated basics room WIP - Updated rooms for consistency Jul 7, 2016
@blurymind
Copy link

blurymind commented Jul 7, 2016

wastedhspace
should I file this as a bug report? :) @shun-iwasawa
You can almost fit another slider in the wasted (yellow space)

@blurymind
Copy link

blurymind commented Jul 7, 2016

#593
#594

This seems to be a persistent problem with the options toolbar. Sorry I am being a pain in the neck about this - but think about how people on 13-15 inch screens feel :)

Just looking at @turtleTooth 's screenshot - try to imagine using the brush size slider to reduce the minimum brush size by 1-2 pixels - with your stylus.

@shun-iwasawa
Copy link
Member

shun-iwasawa commented Jul 8, 2016

@blurymind

should I file this as a bug report? :) @shun-iwasawa
You can almost fit another slider in the wasted (yellow space)

Please check if the style sheets in $TOONZCONFIG/qss are updated. Note that they will NOT be overwritten if they already exist (since they might be customized by users).

Update: Oh sorry, this mention should be posted to @turtleTooth

@blurymind
Copy link

@shun-iwasawa thank you - that fixed it! :)

@ghost ghost changed the title WIP - Updated rooms for consistency Updated rooms for consistency Jul 9, 2016
@ghost
Copy link
Author

ghost commented Jul 9, 2016

These changes were made to all rooms up through Palette:

  • Made the tool option bar across the entire top.
  • Made the tool bar fill the side

Also:

  • Changed Pltedit to Palette - Easier to understand
  • Added Pencil Test to Scan & Cleanup menu

@shun-iwasawa The first time the program is loaded, the Pencil Test doesn't show up in the menu, but it shows up after that. Why is that?

@ghost
Copy link
Author

ghost commented Jul 25, 2016

The first time the program is loaded, the Pencil Test doesn't show up in the menu, but it shows up after that. Why is that?

Figured it out for a different PR I'm working on.

@shun-iwasawa
Copy link
Member

Jenkins

@shun-iwasawa
Copy link
Member

LGTM

@shun-iwasawa shun-iwasawa merged commit bc0379c into opentoonz:master Aug 4, 2016
@ghost ghost deleted the basics branch August 4, 2016 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants