Fix crash reading level (TLZ) file #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- double fclose call (readVersion closed the file, however this is already closed when the class is freed) - buffer overrun reading a char pointer which isn't NULL terminated. use memcmp instead.
|
Accidentally pushed the branch to this repo, since removed but seems to have confused travis-ci. |
|
Jenkins, test this. |
|
OK. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(readVersion closed the file, however this is already closed when the class is freed)
The error was that setting the file pointer to NULL only changed the local value.
It could be passed as a reference or pointer to pointer, however since its closed when the class is freed, not sure its worth extra hassles.
\0terminated.use memcmp instead.