Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soundtrack export #744

Merged
merged 8 commits into from Nov 28, 2017
Merged

Soundtrack export #744

merged 8 commits into from Nov 28, 2017

Conversation

ghost
Copy link

@ghost ghost commented Aug 19, 2016

Adds option to export soundtrack #737
This uses the built in wav format, so ffmpeg is not needed.

@ghost ghost mentioned this pull request Aug 29, 2016
@@ -1603,6 +1603,7 @@ void MainWindow::defineActions() {
createMenuFileAction(MI_Render, tr("&Render"), "Ctrl+Shift+R");
createMenuFileAction(MI_FastRender, tr("&Fast Render to MP4"), "Alt+R");
createMenuFileAction(MI_Preview, tr("&Preview"), "Ctrl+R");
createMenuFileAction(MI_SoundTrack, tr("&Export Soundtrack"), "Alt+S");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set another default shortcut key since Alt+S is already set for Startup Popup .
Or you can just remove the default shortcut if this command seems to be triggered not so often.

@ghost
Copy link
Author

ghost commented Nov 28, 2017

Good call.

@shun-iwasawa
Copy link
Member

Jenkins

@shun-iwasawa
Copy link
Member

LGTM Thank you @turtleTooth

@shun-iwasawa shun-iwasawa merged commit 905d131 into opentoonz:master Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant