Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed gif import #924

Merged
merged 2 commits into from Nov 24, 2016
Merged

Fixed gif import #924

merged 2 commits into from Nov 24, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2016

I broke gif import on #827

This fixes it.

@ideasman42
Copy link
Collaborator

ideasman42 commented Nov 17, 2016

Since there are 4x QRegExp 's, wouldn't it be better to make a static function? filepath_clean_for_ffmpeg or something like this?

@ghost
Copy link
Author

ghost commented Nov 17, 2016

@ideasman42 There you go again making sense.

@ghost
Copy link
Author

ghost commented Nov 22, 2016

@shun-iwasawa This is a pretty simple PR. Would you mind doing a quick look. I would hate for the next release to have broken gif import. (Sorry I broke it in the first place)

@shun-iwasawa
Copy link
Member

Confirmed that GIF files can be imported properly now. Jenkins

@shun-iwasawa
Copy link
Member

LGTM. @turtleTooth thank you for the fix!

@shun-iwasawa shun-iwasawa merged commit 686e82a into opentoonz:master Nov 24, 2016
@ghost ghost deleted the gifimport branch June 8, 2017 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants