Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash of lzocompres and lzodecompress #95

Merged
merged 1 commit into from Apr 13, 2016
Merged

Fix crash of lzocompres and lzodecompress #95

merged 1 commit into from Apr 13, 2016

Conversation

kusano
Copy link
Contributor

@kusano kusano commented Mar 28, 2016

Without stdlib.h malloc is assumed to return int, which is not compatible with void * in x64.
#91

@kusano
Fix crash of lzocompres and lzodecompress
d191aad 
Without stdlib.h malloc is assumed to return int, which is not compatible with void * in x64.
@linkmauve
Copy link

Is this also reported upstream?

@kusano
Copy link
Contributor Author

kusano commented Mar 29, 2016

No.
Files in thirdparty/lzo/driver/ are not LZO original.

@mich181189
Copy link

Ah isn't C's default into behaviour wonderful!

Luckilly it's a simple fix though! What's with the io.h include? Is that for a similar problem?

@kusano
Copy link
Contributor Author

kusano commented Mar 31, 2016

@mich181189
Because _setmode is in io.h.
Although _setmode actually returns int, eliminating warnings is meaningful.

@skitaoka
Copy link
Member

LGTM

@skitaoka skitaoka merged commit 818c53f into opentoonz:master Apr 13, 2016
@yamisama yamisama mentioned this pull request Jul 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kusano @linkmauve @mich181189 @skitaoka