Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix span finishing when response interceptor is called twice for disabled auth caching #20

Merged
merged 2 commits into from
Nov 21, 2019
Merged

fix span finishing when response interceptor is called twice for disabled auth caching #20

merged 2 commits into from
Nov 21, 2019

Conversation

malafeev
Copy link
Contributor

No description provided.

@malafeev
#18 span reports 401 http status on success
916a3b0 
Signed-off-by: Sergei Malafeev <sergeymalafeev@gmail.com>
@malafeev
add additional check for status
c8a8d76 
Signed-off-by: Sergei Malafeev <sergeymalafeev@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 97

  • 0 of 22 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-3.3%) to 39.004%
Changes Missing Coverage Covered Lines Changed/Added Lines %
opentracing-elasticsearch-client-common/src/main/java/io/opentracing/contrib/elasticsearch/common/TracingHttpClientConfigCallback.java 0 22 0.0%
Files with Coverage Reduction New Missed Lines %
opentracing-elasticsearch-client-common/src/main/java/io/opentracing/contrib/elasticsearch/common/TracingHttpClientConfigCallback.java 1 0.0%
Totals Coverage Status
Change from base Build 94: -3.3%
Covered Lines: 94
Relevant Lines: 241
💛 - Coveralls

@malafeev malafeev merged commit 6225758 into master Nov 21, 2019
@malafeev malafeev deleted the fix-auth branch November 21, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@malafeev @coveralls