Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to multi module project to support Elasticsearch 5 and 6 #5

Merged
merged 2 commits into from Jul 12, 2018
Merged

Migrate to multi module project to support Elasticsearch 5 and 6 #5

merged 2 commits into from Jul 12, 2018

Conversation

malafeev
Copy link
Contributor

fixing #4

@malafeev
#4 create separate modules for Elasticsearch 5 and Elasticsearch 6
ee0bfe4 
Signed-off-by: Sergei Malafeev <sergeymalafeev@gmail.com>
@malafeev
Update README
2152e86 
Signed-off-by: Sergei Malafeev <sergeymalafeev@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 28

  • 25 of 35 (71.43%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.05%) to 67.742%
Changes Missing Coverage Covered Lines Changed/Added Lines %
opentracing-elasticsearch6-client/src/main/java/io/opentracing/contrib/elasticsearch6/TracingResponseListener.java 12 16 75.0%
opentracing-elasticsearch6-client/src/main/java/io/opentracing/contrib/elasticsearch6/TracingPreBuiltTransportClient.java 10 16 62.5%
Totals Coverage Status
Change from base Build 25: -2.05%
Covered Lines: 42
Relevant Lines: 62
💛 - Coveralls

@malafeev malafeev merged commit 38c5354 into master Jul 12, 2018
@malafeev malafeev deleted the es_versions branch July 12, 2018 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@malafeev @coveralls