feat: enhance API to inject specific tracer instance into #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 64
💛 - Coveralls |
malafeev
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently java-jdbc only supports tracer instance distribution through static GlobalTracer mechanism.
To support distribution by injection API has been enhanced. In case no tracer is injected backward compatibility is kept by fallback to GlobalTracer.get().
This allows to write unittests, for java-jdbc and components that use this lib, without usage of reflection to reset GlobalTracer registration.
Furthermore it allows to use this integration lib within software where GlobalTracer.get() can't be used.
(limitation: the component has to have access to connection creation code)