Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DynamicProxy #59

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Implement DynamicProxy #59

merged 1 commit into from
Jan 10, 2020

Conversation

safris
Copy link
Contributor

@safris safris commented Jan 10, 2020

This PR partially solves the "wrapper issue", where consumers of the JDBC API upcast JDBC interfaces to more specific classes or interfaces of a specific vendor.

@coveralls
Copy link

coveralls commented Jan 10, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 211

  • 8 of 29 (27.59%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 47.732%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/io/opentracing/contrib/jdbc/DynamicProxy.java 3 4 75.0%
src/main/java/io/opentracing/contrib/jdbc/TracingConnection.java 4 24 16.67%
Totals Coverage Status
Change from base Build 209: -0.03%
Covered Lines: 442
Relevant Lines: 926
💛 - Coveralls

@safris safris mentioned this pull request Jan 10, 2020
Open
@malafeev malafeev merged commit e55efdf into opentracing-contrib:master Jan 10, 2020
@rlubke rlubke mentioned this pull request Jan 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@safris @coveralls @malafeev