Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method name should be "parse" not "parser" #75

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Method name should be "parse" not "parser" #75

merged 1 commit into from
Jun 17, 2020

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jun 17, 2020

Deprecate method "parser" and introduce a new method "parse"

@coveralls
Copy link

coveralls commented Jun 17, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 256

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 48.004%
Totals Coverage Status
Change from base Build 253: 0.05%
Covered Lines: 469
Relevant Lines: 977
💛 - Coveralls

@quaff
Method name should be "parse" not "parser"
a69c5e7 
Deprecate method "parser" and introduce a new method "parse"
@malafeev malafeev merged commit 37b61f1 into opentracing-contrib:master Jun 17, 2020
@quaff quaff deleted the patch-1 branch June 17, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@quaff @coveralls @malafeev