Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change $ to _ in DASH replace string #44

Merged

Conversation

miensol
Copy link
Contributor

@miensol miensol commented Oct 15, 2020

When using SQS as a JMS backend the JmsTextMapInjectAdapter produces a SQSMessage which is rejected by SQS service. As per SQS docs:

The message attribute name can contain the following characters: A-Z, a-z, 0-9, underscore (_), hyphen (-), and period (.). The following restrictions apply:

I think it's safe to change the "-" replacement a bit and remove "$".

When using SQS as a JMS backend the  JmsTextMapInjectAdapter produces a SQSMessage which is rejected by SQS service. As per SQS docs:

> The message attribute name can contain the following characters: A-Z, a-z, 0-9, underscore (_), hyphen (-), and period (.). The following restrictions apply:
@coveralls
Copy link

Pull Request Test Coverage Report for Build 170

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 29.714%

Totals Coverage Status
Change from base Build 169: 0.0%
Covered Lines: 208
Relevant Lines: 700

💛 - Coveralls

@marcin-kwiatkowski
Copy link

+1 :D

@malafeev malafeev merged commit 21052ff into opentracing-contrib:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants