Skip to content

Commit

Permalink
Add public support for SpanDecorators (#78)
Browse files Browse the repository at this point in the history
Changes the visibility for `buildAndFinishChildSpan` and `buildAndInjectSpan` to be public for all methods so that a custom list of SpanDecorators can be provided. This is necessary when outside the `TracingKafkaConsumer` and `TracingKafkaProducer`. An example would be custom tracing interceptors for use with kafka connect.
  • Loading branch information
mviamari committed Jul 30, 2020
1 parent 4cd6b74 commit 4bdbb02
Showing 1 changed file with 2 additions and 2 deletions.
Expand Up @@ -68,7 +68,7 @@ public static <K, V> Span buildAndInjectSpan(ProducerRecord<K, V> record, Tracer
Collections.singletonList(SpanDecorator.STANDARD_TAGS));
}

static <K, V> Span buildAndInjectSpan(ProducerRecord<K, V> record, Tracer tracer,
public static <K, V> Span buildAndInjectSpan(ProducerRecord<K, V> record, Tracer tracer,
BiFunction<String, ProducerRecord, String> producerSpanNameProvider,
SpanContext parent, Collection<SpanDecorator> spanDecorators) {
String producerOper =
Expand Down Expand Up @@ -112,7 +112,7 @@ public static <K, V> void buildAndFinishChildSpan(ConsumerRecord<K, V> record, T
Collections.singletonList(SpanDecorator.STANDARD_TAGS));
}

static <K, V> void buildAndFinishChildSpan(ConsumerRecord<K, V> record, Tracer tracer,
public static <K, V> void buildAndFinishChildSpan(ConsumerRecord<K, V> record, Tracer tracer,
BiFunction<String, ConsumerRecord, String> consumerSpanNameProvider,
Collection<SpanDecorator> spanDecorators) {
SpanContext parentContext = TracingKafkaUtils.extractSpanContext(record.headers(), tracer);
Expand Down

0 comments on commit 4bdbb02

Please sign in to comment.