Custom Span Name #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Span name
Pull Request Test Coverage Report for Build 28
💛 - Coveralls |
malafeev
reviewed
Jul 4, 2018
pom.xml
Outdated
| @@ -55,7 +55,7 @@ | |||
| </issueManagement> | |||
|
|
|||
| <properties> | |||
| <java.version>1.7</java.version> | |||
| <java.version>1.8</java.version> | |||
There was a problem hiding this comment.
MongoDriver support java 1.6+
So I think we cannot upgrade java version until MongoDriver will require it.
malafeev
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes allow the user to customize the span name by providing a function to the TracingMongoClient that alters the span name based on the user's needs. A function to add a prefix to the span name has already been provided in the MongoSpanNameProvider class. The function default will just provide the operation name.